Master construction wi bom dev#18
Draft
trcazier wants to merge 6 commits into
Draft
Conversation
trcazier
force-pushed
the
master-construction-wi-bom-dev
branch
3 times, most recently
from
July 2, 2026 13:47
586d3a2 to
25ea2db
Compare
vava-odoo
reviewed
Jul 6, 2026
vava-odoo
left a comment
vava-odoo
left a comment
Collaborator
There was a problem hiding this comment.
I skipped wbs for now
trcazier
force-pushed
the
master-construction-wi-bom-dev
branch
from
July 7, 2026 11:04
e3f2b80 to
e6c1f83
Compare
trcazier
force-pushed
the
master-construction-wi-bom-poc-trcaz
branch
from
July 7, 2026 11:11
00cbcb5 to
48c1406
Compare
trcazier
force-pushed
the
master-construction-wi-bom-dev
branch
2 times, most recently
from
July 9, 2026 10:18
da42bb5 to
cdff1b4
Compare
vava-odoo
reviewed
Jul 10, 2026
| <field name="readonly" eval="True"/> | ||
| <field name="depends">sale_line_id,sale_line_id.move_ids,sale_line_id.move_ids.product_uom_qty</field> | ||
| <field name="compute"><![CDATA[ | ||
| for record in self: record['x_total_qty'] = sum(record.sale_line_id.move_ids.mapped('product_uom_qty')) |
Collaborator
There was a problem hiding this comment.
I like mapped/filtered too, but this version more efficient (only one loop)
Suggested change
| for record in self: record['x_total_qty'] = sum(record.sale_line_id.move_ids.mapped('product_uom_qty')) | |
| for record in self: record['x_total_qty'] = sum(move.product_uom_qty for move in record.sale_line_id.move_ids) |
Collaborator
There was a problem hiding this comment.
and how do you handle different uom? wouldn't it make sense to use product_qty instead?
Author
There was a problem hiding this comment.
What do you mean? How would it be possible for the same product to have different uoms?
Collaborator
There was a problem hiding this comment.
yes, see with Loïc please
Comment on lines
+133
to
+136
| # Force unselected/unaffected moves on these pickings to strictly backorder | ||
| for picking in pickings_to_validate: | ||
| if (unaffected_moves := picking.move_ids - processed_moves): | ||
| unaffected_moves.write({'quantity': 0.0, 'picked': False}) |
| <field name="depends">price_subtotal,move_ids.x_increment_percent</field> | ||
| <field name="store" eval="False"/> | ||
| <field name="compute"><![CDATA[ | ||
| for sol in self: sol['x_invoice_increment'] = sol.price_subtotal * sum(sol.move_ids.mapped('x_increment_percent')) |
Collaborator
There was a problem hiding this comment.
why does the increment include the price subtotal?
Author
There was a problem hiding this comment.
- This is the way it was before (not my code)
- I think it's supposed to be the difference in price between the previous and current invoice
trcazier
force-pushed
the
master-construction-wi-bom-dev
branch
from
July 15, 2026 08:19
c3ea53e to
d7e596d
Compare
trcazier
force-pushed
the
master-construction-wi-bom-poc-trcaz
branch
3 times, most recently
from
July 15, 2026 11:28
8cd8649 to
0d55732
Compare
trcazier
force-pushed
the
master-construction-wi-bom-dev
branch
from
July 15, 2026 12:28
d7e596d to
1a7772c
Compare
trcazier
force-pushed
the
master-construction-wi-bom-poc-trcaz
branch
2 times, most recently
from
July 16, 2026 07:23
12b59e7 to
5387d65
Compare
trcazier
force-pushed
the
master-construction-wi-bom-dev
branch
11 times, most recently
from
July 17, 2026 09:22
c5b61f5 to
c91b486
Compare
… set BOM price on SOL on BOM change [IMP] construction_developer: 12. remove price & margin from bom, check cost instead of price, automate bom cost propagation to SOL
trcazier
force-pushed
the
master-construction-wi-bom-dev
branch
from
July 17, 2026 09:24
c91b486 to
238fd06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.