Conversation
…s (fixes Gmail attachment 404s)
googsvg
left a comment
There was a problem hiding this comment.
Fix linter, add to changelog md
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
============================================
+ Coverage 81.81% 83.73% +1.92%
- Complexity 450 486 +36
============================================
Files 44 44
Lines 1292 1359 +67
Branches 111 115 +4
============================================
+ Hits 1057 1138 +81
+ Misses 168 149 -19
- Partials 67 72 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AaronDDM
left a comment
There was a problem hiding this comment.
Good morning! Nice fix — the double-encoding was hitting every resource, not just attachments, so routing pre-encoded paths through addEncodedPathSegments is the right call, and the dedicated test for the v0:...=:... attachment id (plus the per-verb encoded tests) covers it well. CHANGELOG unreleased entry is present. Approving.
Two non-blocking notes left inline (grant identifier is no longer percent-encoded, and the parallel *Encoded API surface). Neither blocks merge.
Related to issue: #329
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.