feat: improves project root detection by always going up the directory tree until we find a project root marker#482
Merged
sidlatau merged 1 commit intoJun 22, 2025
Conversation
…y tree until we find a project root marker
sidlatau
approved these changes
Jun 22, 2025
This was referenced Jun 29, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the use of commands in monorepos as we always go up the directory tree searching for the nearest project root marker,
instead of relying on the LSP's root dir which is set to be the project root of whichever project was open when the LSP got attached.