ci: migrate Go test pipeline from CircleCI to GitHub Actions (V6.2)#4317
Merged
Conversation
Backport of #4250 and #4259 from master, limited to CI: - add .github/workflows/go-test.yaml, remove .circleci/config.yml - build-images: build only linux/amd64 on PRs, multi-arch on push/tag - e2e-tests: enable GHA layer cache - drop brittle DNS-error / readdir-order test assertions exposed by the ubuntu-latest runner (same fixes as #4250) so go-test passes Assisted by AI
reinkrul
requested review from
gerardsn,
stevenvegt and
woutslakhorst
as code owners
Contributor
❌ 1 blocking issue (1 total)
|
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (1)
🛟 Help
|
stevenvegt
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the CircleCI→GitHub Actions migration to V6.2.
Ports two merged master PRs:
CI changes
.github/workflows/go-test.yaml; remove.circleci/config.ymlbuild-images: build onlylinux/amd64on PRs, full multi-arch on push/tag (arm under QEMU is slow and adds no PR signal)e2e-tests: enable GHA layer cache (type=gha,scope=e2e)Test changes
crypto/storage/vaultanddidman/api/v1tests. They matched Go net-package error strings (no such host/Temporary failure in name resolution), which differ on theubuntu-latestrunner (systemd-resolved returnsserver misbehaving). Therequire.Error+ nil-result checks still cover the contract.Production code change
policy/local.go:loadFromDirectorynow usesos.ReadDirinstead ofos.Open+dir.Readdir(0).Readdir(0)returned directory entries in filesystem order, so duplicate-scope detection processed.jsonfiles in a non-deterministic order across platforms.os.ReadDirreturns entries sorted by filename, making policy load order — and the duplicate-scope error it reports — deterministic. No change to which mappings are loaded; only the order in which files are read and thus which file is named when two declare the same scope.All three changes are ported verbatim from #4250.