Meta fixes#4036
Open
carpawell wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4036 +/- ##
==========================================
+ Coverage 26.58% 26.76% +0.18%
==========================================
Files 687 688 +1
Lines 46591 46721 +130
==========================================
+ Hits 12384 12504 +120
- Misses 33065 33068 +3
- Partials 1142 1149 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
carpawell
force-pushed
the
fix/meta/drop-external-batching
branch
2 times, most recently
from
ba60b62 to
4337bbe
Compare
This speed the second index persisting up. Closes #4032. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
It should always be like that, and it was, but starting from some refactoring commit, it started to be a line in `saveObject` local func. Without this fix, distributing split objects breaks at LINK object, which is tried with doubled signatures. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
force-pushed
the
fix/meta/drop-external-batching
branch
from
4337bbe to
30bed47
Compare
roman-khimov
approved these changes
Jun 23, 2026
| const ( | ||
| maxBuffSize = 100 | ||
| maxBatchDelay = time.Second | ||
| maxBatchDelay = blobstorconfig.DefaultFlushInterval |
Member
There was a problem hiding this comment.
Not following real configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to delay for so long while metabase has its own batching. Closes ##4032.