object/get: make internal payload-only GETs conditional on eACL recheck#4029
Open
End-rey wants to merge 1 commit into
Open
object/get: make internal payload-only GETs conditional on eACL recheck#4029End-rey wants to merge 1 commit into
End-rey wants to merge 1 commit into
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
Propagate the existing `recheckEACL` signal through the GET path and use it when preparing internal remote GET requests. Mark internal requests as payload-only only when no header-based eACL recheck is needed. If recheck may be required, keep fetching the header so matching eACL rules can still be evaluated correctly. Closes #4028. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4029 +/- ##
==========================================
+ Coverage 26.97% 26.99% +0.02%
==========================================
Files 684 684
Lines 46520 46549 +29
==========================================
+ Hits 12549 12568 +19
- Misses 32787 32794 +7
- Partials 1184 1187 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roman-khimov
left a comment
roman-khimov
left a comment
Member
There was a problem hiding this comment.
It looks good, but let's wait for #4021 to get in first.
carpawell
approved these changes
Jun 19, 2026
Member
|
Conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4028.