sn/meta: fix applying chain defaults#4027
Merged
Merged
Conversation
carpawell
requested review from
End-rey,
cthulhu-rider and
roman-khimov
as code owners
Also move every magic (currently) number config values to `applyMetachainDefaults` func to have them in a single place (block times are a different story). Closes #4026. Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
carpawell
force-pushed
the
fix/meta/sn-panics
branch
from
820b0a1 to
bab6eb6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4027 +/- ##
==========================================
- Coverage 26.97% 26.97% -0.01%
==========================================
Files 684 684
Lines 46521 46522 +1
==========================================
- Hits 12551 12547 -4
- Misses 32786 32789 +3
- Partials 1184 1186 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also move every magic (currently) number config values to
applyMetachainDefaultsfunc to have them in a single place (block times are a different story).