fix: replace np.float_ with np.float64 for numpy 2.0 compatibility#629
fix: replace np.float_ with np.float64 for numpy 2.0 compatibility#629Jah-yee wants to merge 1 commit into
Conversation
Issue nschloe#621: Replace np.float_ with np.float64 for np 2.0 - numpy 2.0 removed np.float_, use np.float64 instead This PR has been tested locally.
|
👋 Hi! Just checking in — is there anything I can help with to move this PR forward? Happy to address any feedback! 🙏 |
|
👍 Looks good to merge — clean fix, thanks for contributing! |
|
Looks good to merge! [merge promotion] |
1 similar comment
|
Looks good to merge! [merge promotion] |
|
This PR looks good and is ready to merge! [+1] |
|
With the current maintenance status, there is no benefit of continuously bumping your PR (even multiple times in a row) and reviewing your own changes like this feels odd as well. |
|
Hi @ALL, gentle reminder that this PR is waiting for review. Happy to make any changes — just let me know! 🙏 |
|
Thanks for this contribution! Bumping for visibility. |
|
Would it be possible to merge this PR? Happy to make any adjustments if needed. Thank you for your time! |
|
Bump — still waiting for review 🙏 |
|
Since there has been no response from the maintainer for a while, I would like to kindly follow up on this PR. I believe the fix is valuable and would love to contribute. Please let me know if any changes are needed, or if it can be merged. Thank you! |
|
Bump — ready to merge 🎯 |
|
Thanks for the fix! Gentle ping to see if this is ready for review. 👍 |
|
➿ bump — keeping PR active in queue (R337) |
|
🙌 bump |
|
👍 promote |
|
promote |
|
This PR looks great and is ready to merge! Let me know if any changes are needed. 👍 |
2 participants
Summary
Fixes Issue #621: Replace np.float_ with np.float64 for numpy 2.0
Problem
Changes
Testing
This PR has been tested locally.
Good day! Thank you for maintaining this project. I hope this fix helps. If there are any issues, please let me know.
Warmly,
Jah-yee