Skip to content

Fix ST_Extent box2d cast being removed by EF simplifier #3828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 1 commit into from
May 4, 2026
+6 −3
Merged

Fix ST_Extent box2d cast being removed by EF simplifier #3828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...pressionTranslators/Internal/NpgsqlNetTopologySuiteAggregateMethodCallTranslatorPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,10 @@ public NpgsqlNetTopologySuiteAggregateMethodTranslator(
if (method == EnvelopeCombineMethod)
{
// ST_Extent returns a PostGIS box2d, which isn't a geometry and has no binary output function.
// Convert it to a geometry first.
// We need to cast the result to geometry. The aggregate function must use 'box2d' as the store type
// so that the cast to geometry is not stripped as a no-op by EF's SqlExpressionSimplifyingExpressionVisitor.
var geometryMapping = GetMapping();

return _sqlExpressionFactory.Convert(
_sqlExpressionFactory.AggregateFunction(
"ST_Extent",
Expand All @@ -131,8 +134,8 @@ public NpgsqlNetTopologySuiteAggregateMethodTranslator(
nullable: true,
argumentsPropagateNullability: [false],
typeof(Geometry),
GetMapping()),
typeof(Geometry), GetMapping());
geometryMapping?.WithStoreTypeAndSize("box2d", null)),
typeof(Geometry), geometryMapping);
}

if (method == UnionMethod || method == GeometryCombineMethod)
Expand Down
Loading