Skip to content

fix: disable broken orama search#8827

Merged
ovflowd merged 1 commit intonodejs:mainfrom
araujogui:fix/disable-orama-search
Apr 18, 2026
Merged

fix: disable broken orama search#8827
ovflowd merged 1 commit intonodejs:mainfrom
araujogui:fix/disable-orama-search

Conversation

@araujogui
Copy link
Copy Markdown
Member

Description

Disable broken orama search

Validation

image

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@araujogui araujogui requested a review from a team as a code owner April 17, 2026 20:04
Copilot AI review requested due to automatic review settings April 17, 2026 20:04
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Apr 17, 2026 8:05pm

Request Review

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 17, 2026

PR Summary

Low Risk
Small UI-only change that hides the search control and tweaks navbar action alignment; no backend, auth, or data-handling logic is touched.

Overview
Disables the navbar search UI by removing the SearchButton import and commenting out its render in withNavBar.tsx.

Adjusts navbar layout by changing the actions container to justify-end so remaining controls (theme, language, GitHub) align to the right.

Reviewed by Cursor Bugbot for commit eb2e9dc. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.90%. Comparing base (5a6d7d2) to head (eb2e9dc).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8827   +/-   ##
=======================================
  Coverage   73.90%   73.90%           
=======================================
  Files         105      105           
  Lines        8889     8889           
  Branches      326      326           
=======================================
  Hits         6569     6569           
  Misses       2319     2319           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the currently broken Orama-powered search entry point in the site’s NavBar, and adjusts NavBar actions layout to account for the removed control.

Changes:

  • Removed the Searchbox button import/usage from the NavBar wrapper.
  • Updated NavBar actions alignment from justify-between to justify-end to reflect the new set of actions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/ui-components/src/Containers/NavBar/index.module.css Adjusts actions layout alignment after removing search control.
apps/site/components/withNavBar.tsx Disables the Searchbox button in the site header/NavBar composition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/site/components/withNavBar.tsx
Comment thread packages/ui-components/src/Containers/NavBar/index.module.css
@araujogui araujogui added the fast-track Fast Tracking PRs label Apr 17, 2026
@araujogui
Copy link
Copy Markdown
Member Author

@nodejs/nodejs-website asking fast-track

@ovflowd ovflowd added this pull request to the merge queue Apr 18, 2026
Merged via the queue into nodejs:main with commit 333d70f Apr 18, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants