Skip to content

quic: Fix wake up blob #64044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martenrichter wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −4
Open

quic: Fix wake up blob #64044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions lib/internal/blob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,9 +455,15 @@ function createBlobReaderStream(reader) {
this.pendingPulls = [];
// Register a wakeup callback that the C++ side can invoke
// when new data is available after a STATUS_BLOCK.
let immediate;
reader.setWakeup(() => {
if (this.pendingPulls.length > 0) {
this.readNext(c);
if (this.pendingPulls.length > 0 &&
typeof immediate === 'undefined') {
// Postpone the execution to the next steps of the event loop
immediate = setImmediate(() => {
immediate = undefined;
this.readNext(c);
});
}
});
},
Expand Down Expand Up @@ -544,7 +550,16 @@ const kMaxBatchChunks = 16;
async function* createBlobReaderIterable(reader, options = kEmptyObject) {
const { getReadError } = options;
let wakeup = PromiseWithResolvers();
reader.setWakeup(wakeup.resolve);
let immediate;
reader.setWakeup(() => {
if (typeof immediate === 'undefined') {
// Postpone the execution to the next steps of the event loop
immediate = setImmediate(() => {
immediate = undefined;
wakeup.resolve?.();
});
}
});

try {
while (true) {
Expand Down Expand Up @@ -591,7 +606,6 @@ async function* createBlobReaderIterable(reader, options = kEmptyObject) {
if (blocked) {
const fin = await wakeup.promise;
wakeup = PromiseWithResolvers();
reader.setWakeup(wakeup.resolve);
// If the wakeup was triggered by FIN (EndReadable), the DataQueue
// is capped. Continue the loop to pull again -- the next pull will
// return EOS. Without this, a race between the data notification
Expand Down
Loading