doc: fix keepAliveTimeout default in http.createServer options#63974
Open
jahanzaib-iqbal-dev wants to merge 1 commit into
Open
doc: fix keepAliveTimeout default in http.createServer options#63974jahanzaib-iqbal-dev wants to merge 1 commit into
jahanzaib-iqbal-dev wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
pimterry
approved these changes
Jun 18, 2026
pimterry
left a comment
pimterry
left a comment
Member
There was a problem hiding this comment.
Good catch, thanks! Change itself looks good, but your commit message is failing linting because it doesn't have a signed-off-by trailer. You'll need to git commit -s --amend (which will add the trailer) and then force push.
PR nodejs#62782 updated the keepAliveTimeout default from 5s to 65s and correctly updated server.keepAliveTimeout (line 2006), but the http.createServer() options table at line 3775 was not updated. Fix the remaining reference to reflect the current default of 65000ms. Signed-off-by: Jahanzaib iqbal <jahanzaib@gsoftconsulting.com>
jahanzaib-iqbal-dev
force-pushed
the
docs/fix-keepalivetimeout-default
branch
from
2e7f41b to
f15a17a
Compare
Author
|
@pimterry thanks for the review! I've added the |
bjohansebas
approved these changes
Jun 18, 2026
bjohansebas
added
the
author ready
efekrskl
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #62782 updated the
keepAliveTimeoutdefault from 5 seconds to 65 seconds and correctly updated theserver.keepAliveTimeoutproperty section, but thehttp.createServer()options table was not updated and still shows**Default:** \5000``.This PR fixes the remaining reference.
Before:
After: