test: wait for debugger pause state on startup#63968
Draft
trivikr wants to merge 1 commit into
Draft
Conversation
The debugger helper waited for the initial break by matching the human-readable break banner. On slow systems the CLI can reach the prompt before that banner is observed, causing flaky timeouts. Probe the debugger CLI state with list() and retry while it reports that execution is not paused. Use the remaining timeout budget for each probe wait so the startup wait still respects the helper timeout. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
56ea5cb to
05886b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the debugger test helper to wait for the debugger CLI
to reach a paused state instead of depending only on the printed
initial break banner.
The helper now probes with
list()and retries while the CLI reportsthat execution is not paused. Each probe wait uses the remaining
timeout budget so the overall startup wait still respects the helper
timeout.
Refs: https://github.com/nodejs/node/actions/runs/27683841143/job/81877654047
Error log
Assisted-by: openai:gpt-5.5