quic: fix get_reader bug that lost data from open streams on FIN#63946
Open
pimterry wants to merge 1 commit into
Open
quic: fix get_reader bug that lost data from open streams on FIN#63946pimterry wants to merge 1 commit into
pimterry wants to merge 1 commit into
Conversation
Signed-off-by: Tim Perry <pimterry@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Ethan-Arrowood
approved these changes
Jun 17, 2026
Qard
approved these changes
Jun 19, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
bjohansebas
added
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you receive a stream, but you don't start reading the body immediately, you can lose the stream body entirely even while the stream is still open.
This happens because
get_readerreturned an empty reader ifis_readable()was false, which happens when the stream's data is finished, even though it may be happily received and ready to read. This happens even if the writable side of the stream is open and the stream is otherwise active as normal.This is reasonably common I think. For an HTTP/3 server where you receive a request and you do anything async before you start reading the body, if the client finishes the body before you start reading it (a small body delivered within the flow control window) you'd just get empty data. Nice easy standalone fix & test.