[v24.x] Revert "stream: noop pause/resume on destroyed streams"

[sxa]

This reverts commit 29b1966 from #62557

Should fix #63487 based on a git bisect run

[nodejs-github-bot]

Review requested:

• @nodejs/streams

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/74035/

[sxa]

Revert on top of v24.x-staging confirmed to have resolved the problem on my local system therefore I am taking this out of draft status.

[sxa]

FYI @nodejs/tsc @nodejs/releasers

[mcollina]

lgtm confirmed

[MikeMcC399]

Successfully tested against cypress@15.15.0👍🏻

---

Cypress already produced a fix for this issue in cypress@15.16.0 so I'm testing against the previous unfixed version cypress@15.15.0.

The Cypress analysis of why it was failing on Windows (always) and Linux (when no unzip installed) is in cypress-io/cypress#33891 (comment). In both cases, extract-zip was being invoked and it failed on Node.js 24.16.0 and Node.js >=26.1.0 with the symptom that unzipping either hung or silently exited, depending on how the installation of the Cypress binary was invoked.

---

Verification

On Windows 11 25H2, in Git Bash with Node.js v24.16.1-pre, built from #63834, installed

cd $(mktemp -d)
npm install cypress@15.15.0 --ignore-scripts # fixed versions >=15.16.0
npx cypress install --force
npx cypress verify

Logs

$ cd $(mktemp -d)
npm install cypress@15.15.0 --ignore-scripts # fixed versions >=15.16.0
npx cypress install --force
npx cypress verify
npm warn cli npm v11.7.0 does not support Node.js v24.16.1-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.

added 175 packages in 6s

53 packages are looking for funding
  run `npm fund` for details
npm warn cli npm v11.7.0 does not support Node.js v24.16.1-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.

Cypress 15.15.0 is installed in C:\Users\mikem\AppData\Local\Cypress\Cache\15.15.0

Installing Cypress (version: 15.15.0)

√  Downloaded Cypress
√  Unzipped Cypress
√  Finished Installation C:\Users\mikem\AppData\Local\Cypress\Cache\15.15.0

You can now open Cypress by running one of the following, depending on your package manager:

- npx cypress open
- yarn cypress open
- pnpm cypress open

https://on.cypress.io/opening-the-app

npm warn cli npm v11.7.0 does not support Node.js v24.16.1-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.

√  Verified Cypress! C:\Users\mikem\AppData\Local\Cypress\Cache\15.15.0\Cypress

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/74050/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/74051/

[github-actions]

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - Revert "stream: noop pause/resume on destroyed streams"
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/27762715319

[github-actions]

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - Revert "stream: noop pause/resume on destroyed streams"
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/27771938741

[sxa]

Landed in 84718082627f

[MattiasBuelens]

@sxa 8471808 doesn't seem to be on v24.x-staging? Or am I missing something?

[sxa]

There was an issue with the signing on the commit not occurring properly so it got rejected as it was pushed up which I've been trying to resolve. Pushed again as 3f54c8b