lib: add Iterator global to primordials, improve iteration object coverage in frozen intrinsics#63698
Closed
Renegade334 wants to merge 4 commits into
Closed
lib: add Iterator global to primordials, improve iteration object coverage in frozen intrinsics#63698Renegade334 wants to merge 4 commits into
Renegade334 wants to merge 4 commits into
Conversation
51aa657 to
00e4207
Compare
Contributor
It's a spec fiction used for defining behavior of other algorithms (for-await over a sync iterator, specifically), not a real thing (although engines might choose to have an internal representation of it for ease of implementation). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63698 +/- ##
==========================================
- Coverage 91.96% 90.35% -1.61%
==========================================
Files 379 732 +353
Lines 166638 236691 +70053
Branches 25497 44583 +19086
==========================================
+ Hits 153242 213867 +60625
- Misses 13099 14563 +1464
- Partials 297 8261 +7964
🚀 New features to boost your workflow:
|
ljharb
reviewed
Jun 2, 2026
ljharb
approved these changes
Jun 2, 2026
This comment has been minimized.
This comment has been minimized.
Collaborator
aduh95
reviewed
Jun 3, 2026
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
00e4207 to
17d237b
Compare
aduh95
reviewed
Jun 11, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Collaborator
Collaborator
|
Landed in 96cff60...f2e3c10 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 13, 2026
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #63698 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 13, 2026
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #63698 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #63698 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #63698 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib: add Iterator global to primordials
iterator_helpers is unflagged in V8 from v24.x.
lib: improve control abstraction coverage in frozen intrinsics
Adds the new internal iteration prototypes (
%IteratorHelperPrototype%,%WrapForValidIteratorPrototype%) to frozen intrinsics, and improves/deduplicates coverage of iterator/generator objects.Note that
%AsyncFromSyncIteratorPrototype%is missing from the iterator spec – this is unresolvable AFAICT.