fix: Build with a correct OpenSSL config on loongarch64#2482
fix: Build with a correct OpenSSL config on loongarch64#2482arrowd wants to merge 1 commit intonodejs:mainfrom
Conversation
MikeMcC399
left a comment
There was a problem hiding this comment.
I can't speak to the loongarch64 target with any experience. I do see that loong64 is listed under https://github.com/nodejs/node/blob/main/BUILDING.md#platform-list as "Support Type: Experimental" though.
If this is generally accepted as a change, it would need to go into the https://github.com/nodejs/docker-node/blob/main/Dockerfile-alpine.template file
The individual Dockerfile, that are used to build, are overwritten by the script update.sh, so it doesn't work to submit a PR to change any of these files directly.
Trying to use asm config makes gyp pick up the fallback x86-64 config instead of loongarch64 one. This in turn leads to -m64 being passed to the compiler.
6e89875 to
87c4b49
Compare
|
Doesn't look like the Official Images support loongarch64 docker-library/official-images#16404, so this doesn't make sense to land. |
MikeMcC399
left a comment
There was a problem hiding this comment.
I see you also tried through alpinelinux/docker-alpine#488 so I guess you won't be surprised that your PR can't be accepted here either.
We also wouldn't have any way to test it in CI as far as I can see, based on the link that @nschonni gave as well.
Can't agree with this statement. Docker itself does support loong64, as well as Podman running in the Docker compat mode. My understanding is that repositories like this one or docker-alpine exist to allow other people, not only Docker Hub builders, to build images. My change removes the need for users to debug and fix Dockerfiles if they're building for loong64. It also do not incur any maintenance burder on you. Why turn back this contribution only because Docker Inc does not want to support loong64? |
|
This repo is used to create the Official Images PRs and some light guidance |
Description
This change sets OPENSSL_ARCH to a correct value for loongarch64 and also passes --openssl-no-asm to the configure script, because there is no asm configuration in gyp files for loongarch64.
Motivation and Context
Trying to use asm config makes gyp pick up the fallback x86-64 config instead of loongarch64 one. This in turn leads to -m64 being passed to the compiler, which finally leads to compilation errors.
Testing Details
docker image buildsuccessfully creates a corresponding image.Types of changes
Checklist