Skip to content

Fix blank clip detail page (undefined var) + type-check the SPA in build #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmbrthirteen merged 1 commit into from
Jun 18, 2026
Merged

Fix blank clip detail page (undefined var) + type-check the SPA in build #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/build-studio.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ here="$(cd "$(dirname "$0")/.." && pwd)"
out="${1:-$here/dist/studio}"
cd "$here"

# Type-check the SPA — vite/esbuild don't, so undefined-var bugs in the client
# would otherwise ship silently (blank pages at runtime).
npx tsc --noEmit -p src/ui/client/tsconfig.json
npm run build # tsc + vite -> dist/ui/web-server.js + dist/ui/public

rm -rf "$out"
Expand Down
2 changes: 1 addition & 1 deletion src/ui/client/ClipDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export default function ClipDetail() {

<div className="clip-detail">
<div className="clip-detail-player">
{file ? <ClipPlayer key={previewUrl} src={previewUrl} onTime={(t) => (playerTime.current = t)} /> : <div className="phone-empty">No rendered output</div>}
{clip.output_path ? <ClipPlayer key={previewUrl} src={previewUrl} onTime={(t) => (playerTime.current = t)} /> : <div className="phone-empty">No rendered output</div>}
<button className="btn btn-ghost btn-sm" style={{ width: "100%", marginTop: 10 }} onClick={() => setReframing(true)}>Reframe (fix camera)</button>
<div className="clip-meta">
<span>{fmt(clip.start_second)}–{fmt(clip.end_second)} · {clip.duration}s</span>
Expand Down
Loading