fix(perf): replace legacy NotesHooks boot registration with typed file event listeners#1836
Open
joshtrichards wants to merge 10 commits intomainfrom
Open
fix(perf): replace legacy NotesHooks boot registration with typed file event listeners#1836joshtrichards wants to merge 10 commits intomainfrom
joshtrichards wants to merge 10 commits intomainfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Six of one half dozen of another... Signed-off-by: Josh <josh.t.richards@gmail.com>
CarlSchwan
approved these changes
Apr 27, 2026
Member
CarlSchwan
left a comment
There was a problem hiding this comment.
Yeah for less legacy hooks \o/
but please wait for one of the maintainer of the app to approve before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refactor:
LazyFoldermaterialization during app bootIt does so by migrating note metadata invalidation from legacy hooks to typed filesystem event listeners.
Why
The previous implementation registered listeners by calling
listenTo()on a lazy root folder duringboot(). That pattern can eagerly initializeIRootFolderjust to register listeners, defeating laziness and adding avoidable request-time overhead.Using
registerEventListener()inApplication::register()makes listener registration declarative and avoids boot-time access to the lazy filesystem root.This is intended to address #1835 and is also a worthwhile cleanup on its own to move Notes away from legacy hook APIs (and since it'd be really really nice to drop support for the old hooks upstream at
nextcloud/server).Changes
NotesHooksregistration pattern fromApplication::boot()Application::register()NoteFileEventsListenerto handle note metadata invalidation for the events formerly handled byNotesHooksNotesHooksBehavior
This refactor is intended to preserve the existing invalidation behavior:
Expected impact
Notes