Skip to content

fix(delete-files): delete all#16941

Merged
alperozturk96 merged 1 commit intomasterfrom
fix/delete-all
Apr 30, 2026
Merged

fix(delete-files): delete all#16941
alperozturk96 merged 1 commit intomasterfrom
fix/delete-all

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

Issue

When user select all files and press deletes, delete all not works

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Copy link
Copy Markdown
Collaborator Author

/backport to stable-33.1.x

/**
* Handles action bar leading button action
*/
@Suppress("NestedBlockDepth")
Copy link
Copy Markdown
Collaborator Author

@alperozturk96 alperozturk96 Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to supress kotlin spotless

private void folderOnItemClick(OCFile file, int position) {
if (requireActivity() instanceof FolderPickerActivity fpa) {
String filenameErrorMessage = FileNameValidator.INSTANCE.checkFileName(file.getFileName(), getCapabilities(), requireContext(), null);
String filenameErrorMessage = FileNameValidator.INSTANCE.checkFileName(file.getFileName(), getCapabilities(), requireContext());
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crash fix

@github-actions
Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/25107759128/artifacts/6706709339
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness7167
Dodgy code218216
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total426420

@github-actions
Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96 alperozturk96 merged commit b4050dd into master Apr 30, 2026
13 of 23 checks passed
@alperozturk96 alperozturk96 deleted the fix/delete-all branch April 30, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant