Pin platforms-js deploys to the packageVersion from metadata.json#74
Open
nadrummond wants to merge 1 commit into
Open
Pin platforms-js deploys to the packageVersion from metadata.json#74nadrummond wants to merge 1 commit into
nadrummond wants to merge 1 commit into
Conversation
The install step referenced steps.latest-json-metadata.outputs.deploymentVersion, an output that was never set, so it expanded to an empty string and 'npm install @n3oltd/platforms-js-<sub>@' resolved the latest dist-tag. Every deploy (QA and prod) therefore shipped whatever was last published, ignoring the version pinned in the deployments repo. The install now uses the packageVersion output (the npm version; the deploymentVersion field is the deployments-repo folder name and is not a valid npm version), and the metadata step fails fast if packageVersion is missing so a bad metadata file can never silently mean latest again. Also removes the n3o-trigger-platforms-js-deployment-qa action, unused once fe-platforms drives QA deployments through the n3o CLI. Part of n3oltd/work#736 (Step 3). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of n3oltd/work#736 (Step 3).
The install step in
n3o-platforms-js-deploy.ymlreferencedsteps.latest-json-metadata.outputs.deploymentVersion— an output the metadata step never sets — so it expanded to an empty string andnpm install "@n3oltd/platforms-js-<sub>@"resolved thelatestdist-tag. Every deploy (QA and prod) shipped whatever was last published, ignoring the version pinned in the deployments repo.Changes
packageVersionoutput. (packageVersionis also the correct field —deploymentVersionis the deployments-repo folder name, e.g.2026.02.04.2, not a valid npm version like2026.2.4-303.)packageVersionis empty/null, so a bad metadata file can never silently meanlatestagain.n3o-trigger-platforms-js-deployment-qaaction, unused once fe-platforms drives QA deployments through the n3o CLI.Merge after n3oltd/fe-platforms#887 has merged and produced at least one fresh metadata commit in the deployments repo. QA's
latest/metadata.jsoncurrently pins2026.2.4-303from February — merging this PR first would roll QA back to that build on the next deploy. The action removal also requires #887 to be merged first, as fe-platformsmainreferences it until then.🤖 Generated with Claude Code