Skip to content
This repository was archived by the owner on Mar 14, 2019. It is now read-only.

Small buildsystem improvements#28

Open
heirecka wants to merge 3 commits into
mujx:masterfrom
heirecka:small-buildsystem-improvements
Open

Small buildsystem improvements#28
heirecka wants to merge 3 commits into
mujx:masterfrom
heirecka:small-buildsystem-improvements

Conversation

@heirecka

Copy link
Copy Markdown

No description provided.

Allowing to build against a system installed copy.
That's what the README suggests and - more importantly - the cmake
config file works with.
Also use angle brackets instead of quotation marks in two cases.
Makes the life of packagers and everybody who wants to build this
easier.

Closes #25.
@mujx

mujx commented Sep 15, 2018

Copy link
Copy Markdown
Owner

Thanks a lot for the work on this one!

Could you also add the nlohmann-json package in appveyor.yml here to fix the Windows build?

edit: I just noticed the linux builds are failing also due to the missing nlohman library which will also need to be installed or provide a way to point to the installed directory.

@mujx

mujx commented Sep 25, 2018

Copy link
Copy Markdown
Owner

@heirecka Any updates on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants