Skip to content

better formspecs #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
The4codeblocks wants to merge 14 commits into
base: master
Choose a base branch
from
Open

better formspecs #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2316a65
null commit, make branch
The4codeblocks Jun 10, 2026
3cbf42d
redone battery box GUI
The4codeblocks Jun 10, 2026
93b6b06
batbox tooltip
The4codeblocks Jun 10, 2026
93a1f8e
generic machine formspec real coordinates
The4codeblocks Jun 16, 2026
bac4d45
Merge branch 'master' into betterbatteryboxgui
The4codeblocks Jun 17, 2026
7f34bfb
generator formspec real coordinates
The4codeblocks Jun 17, 2026
42a57de
Merge remote-tracking branch 'origin/betterbatteryboxgui' into better…
The4codeblocks Jun 17, 2026
2bcc394
mcl compat battery box
The4codeblocks Jun 17, 2026
d0ebbb1
oops
The4codeblocks Jun 17, 2026
46bdf7d
oops
The4codeblocks Jun 17, 2026
a194ede
comment
The4codeblocks Jun 17, 2026
2fb9192
machine base mcl compat
The4codeblocks Jun 17, 2026
9d0657b
fuelfired generator mcl compat
The4codeblocks Jun 17, 2026
71e057b
selfcontained injector real coördinates
The4codeblocks Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 88 additions & 39 deletions technic/machines/other/injector.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,50 +13,99 @@ local param2_to_under = {
[4] = {x= 1,y= 0,z= 0}, [5] = {x= 0,y= 1,z= 0}
}

local size = core.get_modpath("mcl_formspec") and "size[9,10]" or "size[8,9]"
local base_formspec = size..
"label[0,0;"..S("Self-Contained Injector").."]"..
"list[context;main;0,2;8,2;]"..
"listring[context;main]"

if core.get_modpath("mcl_formspec") then
base_formspec = base_formspec..
mcl_formspec.get_itemslot_bg(0,2,8,2)..
-- player inventory
"list[current_player;main;0,5.5;9,3;9]"..
mcl_formspec.get_itemslot_bg(0,5.5,9,3)..
"list[current_player;main;0,8.74;9,1;]"..
mcl_formspec.get_itemslot_bg(0,8.74,9,1)..
"listring[current_player;main]"
local function get_itemslot_bg(x, y, w, h) -- mcl hasn't moved to real co-ordinates yet
local out = ""
for i = 0, w - 1, 1 do
for j = 0, h - 1, 1 do
out = out .. "image[" .. x + i*1.25 .. "," .. y + j*1.25 .. ";1,1;mcl_formspec_itemslot.png]"
end
end
return out
end
local has_mcl_formspec = core.global_exists("mcl_formspec")

local margin_x, margin_y = 0.5, 0.5
local slot_size, slot_spacing = 1, 0.25
local slot_interval = slot_size + slot_spacing
local separation = 0.5
local machine_section_h = 4.5
local plrinv_w, plrinv_h = 8, 4
if has_mcl_formspec then
plrinv_w = 9
plrinv_h = 4.5
end
local body_width = plrinv_w * slot_interval - slot_spacing
local plrinv_y = machine_section_h + separation
local body_height = plrinv_y + plrinv_h * slot_interval - slot_spacing

local subject_w = slot_interval * 8 - slot_spacing
local subject_x, subject_y = (body_width - subject_w)/2, 0.5
local src_x, src_y = subject_x, subject_y + slot_interval

local base_formspec = {}

table.insert(base_formspec, "formspec_version[4]")
table.insert(base_formspec, ("size[%.2f,%.2f]"):format(2 * margin_x + body_width, 2 * margin_y + body_height))
table.insert(base_formspec, ("label[%.2f,%.2f;%s]")
:format(margin_x, margin_y, S("Self-Contained Injector")))

-- player inventory
if has_mcl_formspec then
local top_inv_y = margin_y + plrinv_y
local hotbar_y = top_inv_y + 3 * slot_interval + slot_spacing
table.insert(base_formspec, get_itemslot_bg(margin_x + src_x, margin_y + src_y, 8,2))
table.insert(base_formspec, get_itemslot_bg(margin_x, top_inv_y, plrinv_w, 3))
table.insert(base_formspec, get_itemslot_bg(margin_x, hotbar_y, plrinv_w,1))
table.insert(base_formspec,("list[current_player;main;%.2f,%.2f;%d,3;9]")
:format(margin_x, top_inv_y, plrinv_w))
table.insert(base_formspec,("list[current_player;main;%.2f,%.2f;%d,1;]")
:format(margin_x, hotbar_y, plrinv_w))
else
base_formspec = base_formspec..
"list[current_player;main;0,5;8,4;]"..
"listring[current_player;main]"
table.insert(base_formspec, ("list[current_player;main;%.2f,%.2f;%d,%d;]")
:format(margin_x, margin_y + plrinv_y, plrinv_w, plrinv_h))
end

table.insert(base_formspec, ("list[context;main;%.2f,%.2f;8,2;]")
:format(margin_x + src_x, margin_y + src_y))

-- listrings
table.insert(base_formspec, "listring[context;main]")
table.insert(base_formspec, "listring[current_player;main]")

base_formspec = table.concat(base_formspec)

local form_buttons = function(meta)
return fs_helpers.cycling_button(
meta,
pipeworks.button_base:gsub("%[0%,4%.3%;1%,0%.6", ("[%.2f,%.2f;%.2f,%.2f")
:format(margin_x, margin_y + machine_section_h - 0.5 + 0.1, 1, 0.5)),
"splitstacks",
{
pipeworks.button_off,
pipeworks.button_on
}
)..pipeworks.button_label:gsub("%[0%.9%,4%.31", ("[%.2f,%.2f")
:format(margin_x + 1, margin_y + machine_section_h - 0.25 + 0.1))
end

local function set_injector_formspec(pos)
local meta = core.get_meta(pos)
local formspec = base_formspec..
fs_helpers.cycling_button(
meta,
pipeworks.button_base,
"splitstacks",
{
pipeworks.button_off,
pipeworks.button_on
}
)..pipeworks.button_label
if meta:get_string("mode") == "whole stacks" then
formspec = formspec.."button[0,1;4,1;mode_item;"..S("Stackwise").."]"
else
formspec = formspec.."button[0,1;4,1;mode_stack;"..S("Itemwise").."]"
end
if core.get_node_timer(pos):is_started() then
formspec = formspec.."button[4,1;4,1;disable;"..S("Enabled").."]"
else
formspec = formspec.."button[4,1;4,1;enable;"..S("Disabled").."]"
end
meta:set_string("formspec", formspec)
local formspec = {base_formspec, form_buttons(meta)}
local is_stackwise = meta:get_string("mode") == "whole stacks"
table.insert(formspec, ("button[%.2f,%.2f;%.2f,%.2f;%s;%s]")
:format(
margin_x + subject_x, margin_y + subject_y, slot_size * 4, slot_size,
is_stackwise and "mode_item" or "mode_stack",
is_stackwise and S("Stackwise") or S("Itemwise")
))
local is_enabled = core.get_node_timer(pos):is_started()
table.insert(formspec, ("button[%.2f,%.2f;%.2f,%.2f;%s;%s]")
:format(
margin_x + subject_x + subject_w - slot_size * 4, margin_y + subject_y, slot_size * 4, slot_size,
is_enabled and "disable" or "enable",
is_enabled and S("Enabled") or S("Disabled")
))
meta:set_string("formspec", table.concat(formspec))
end

core.register_node("technic:injector", {
Expand Down
201 changes: 146 additions & 55 deletions technic/machines/register/battery_box.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,22 @@

local digilines_path = core.get_modpath("digilines")
local has_digilines = core.global_exists("digilines")

local S = technic.getter
local tube_entry = "^pipeworks_tube_connection_metallic.png"
local cable_entry = "^technic_cable_connection_overlay.png"
local mat = technic.materials

local function get_itemslot_bg(x, y, w, h) -- mcl hasn't moved to real co-ordinates yet
local out = ""
for i = 0, w - 1, 1 do
for j = 0, h - 1, 1 do
out = out .. "image[" .. x + i*1.25 .. "," .. y + j*1.25 .. ";1,1;mcl_formspec_itemslot.png]"
end
end
return out
end


-- Battery recipes:
-- Tin-copper recipe:
core.register_craft({
Expand Down Expand Up @@ -114,66 +125,147 @@ function technic.register_battery_box(nodename, data)
local tier = def.tier
local ltier = string.lower(tier)

local size = core.get_modpath("mcl_formspec") and "size[9,9]" or "size[8,9]"
local formspec =
size..
"image[1,1;1,2;technic_power_meter_bg.png]"..
"list[context;src;3,1;1,1;]"..
"image[4,1;1,1;technic_battery_reload.png]"..
"list[context;dst;5,1;1,1;]"..
"label[0,0;"..S("@1 Battery Box", S(tier)).."]"..
"label[3,0;"..S("Charge").."]"..
"label[5,0;"..S("Discharge").."]"..
"label[1,3;"..S("Power level").."]"..
(def.upgrade and
"list[context;upgrade1;3.5,3;1,1;]"..
"list[context;upgrade2;4.5,3;1,1;]"..
"label[3.5,4;"..S("Upgrade Slots").."]"
or "")

if core.get_modpath("mcl_formspec") then
formspec = formspec..
mcl_formspec.get_itemslot_bg(3,1,1,1)..
mcl_formspec.get_itemslot_bg(5,1,1,1)..
-- player inventory
"list[current_player;main;0,4.5;9,3;9]"..
mcl_formspec.get_itemslot_bg(0,4.5,9,3)..
"list[current_player;main;0,7.74;9,1;]"..
mcl_formspec.get_itemslot_bg(0,7.74,9,1)..
-- upgrade
(def.upgrade and
mcl_formspec.get_itemslot_bg(3.5,3,1,1)..
mcl_formspec.get_itemslot_bg(4.5,3,1,1)
or "")
local has_mcl_formspec = core.global_exists("mcl_formspec")
local has_upgrades = def.upgrade

local slot_size, slot_spacing = 1, 0.25
local slot_interval = slot_size + slot_spacing
local margin_x, margin_y = 0.5, 0.5
local separation = 0.5
local machine_section_h = 5
local plrinv_w, plrinv_h = 8, 4
if has_mcl_formspec then
plrinv_w = 9
plrinv_h = 4.25
end
local body_width = plrinv_w * slot_interval - slot_spacing
local plrinv_y = machine_section_h + separation
local body_height = plrinv_y + plrinv_h * slot_interval - slot_spacing

local charge_arrow_length = 2
local charge_arrow_margin = 0.25
local charge_arrowhead_length = 0.25
local upgrades_x, upgrades_y = body_width - (slot_size + slot_spacing + slot_size), machine_section_h - slot_size
local energy_bar_w, energy_bar_h = 1, 2.5
local subject_w = energy_bar_w + charge_arrow_margin * 2 + charge_arrow_length + slot_size
local subject_h = energy_bar_h
local energy_bar_x, energy_bar_y = (body_width - subject_w)/2, 0.75
local label_offset = 0.2

local formspec_base = {}
table.insert(formspec_base, "formspec_version[4]")
table.insert(formspec_base, ("size[%.2f,%.2f]"):format(2 * margin_x + body_width, 2 * margin_y + body_height))
local _charge_arrow_begin = margin_x + energy_bar_x + energy_bar_w + charge_arrow_margin
local _charge_slot_x = margin_x + energy_bar_x + subject_w - slot_size
local _charge_begin_y = margin_y + energy_bar_y
local _arrow_thickness = charge_arrowhead_length
-- player inventory
if has_mcl_formspec then
local top_inv_y = margin_y + plrinv_y
local hotbar_y = top_inv_y + 3 * slot_interval + slot_spacing
table.insert(formspec_base, get_itemslot_bg(_charge_slot_x, _charge_begin_y,1,1))
table.insert(formspec_base, get_itemslot_bg(_charge_slot_x, _charge_begin_y + subject_h - slot_size, 1,1))
table.insert(formspec_base, get_itemslot_bg(margin_x, top_inv_y, plrinv_w, 3))
table.insert(formspec_base, get_itemslot_bg(margin_x, hotbar_y, plrinv_w,1))
table.insert(formspec_base,("list[current_player;main;%.2f,%.2f;%d,3;9]")
:format(margin_x, top_inv_y, plrinv_w))
table.insert(formspec_base,("list[current_player;main;%.2f,%.2f;%d,1;]")
:format(margin_x, hotbar_y, plrinv_w))
else
formspec = formspec..
"list[current_player;main;0,5;8,4;]"
table.insert(formspec_base, ("list[current_player;main;%.2f,%.2f;%d,%d;]")
:format(margin_x, margin_y + plrinv_y, plrinv_w, plrinv_h))
end
table.insert(formspec_base, ("list[context;src;%.2f,%.2f;1,1;]")
:format(_charge_slot_x, _charge_begin_y))
table.insert(formspec_base, ("list[context;dst;%.2f,%.2f;1,1;]")
:format(_charge_slot_x, _charge_begin_y + subject_h - slot_size))
table.insert(formspec_base, ("label[%.2f,%.2f;%s]")
:format(_charge_slot_x, _charge_begin_y + slot_size + label_offset, S("Charge")))
table.insert(formspec_base, ("label[%.2f,%.2f;%s]")
:format(_charge_slot_x, _charge_begin_y + subject_h + label_offset, S("Discharge")))
table.insert(formspec_base, ("image[%.2f,%.2f;%.2f,%.2f;%s]")
:format(
_charge_arrow_begin, _charge_begin_y + (slot_size - _arrow_thickness)/2,
charge_arrow_length - charge_arrowhead_length, _arrow_thickness,
"blank.png^[invert:ga"
))
table.insert(formspec_base, ("image[%.2f,%.2f;%.2f,%.2f;%s]")
:format(
_charge_arrow_begin + charge_arrow_length - charge_arrowhead_length,
_charge_begin_y + slot_size/2 - charge_arrowhead_length,
charge_arrowhead_length, charge_arrowhead_length * 2,
"technic_arrowhead.png^[invert:rb"
))
table.insert(formspec_base, ("image[%.2f,%.2f;%.2f,%.2f;%s]")
:format(
_charge_arrow_begin + charge_arrowhead_length,
_charge_begin_y + subject_h - (slot_size + _arrow_thickness)/2,
charge_arrow_length - charge_arrowhead_length, _arrow_thickness,
"blank.png^[invert:ra"
))
table.insert(formspec_base, ("image[%.2f,%.2f;%.2f,%.2f;%s]")
:format(
_charge_arrow_begin,
_charge_begin_y + subject_h - slot_size/2 - charge_arrowhead_length,
charge_arrowhead_length, charge_arrowhead_length * 2,
"technic_arrowhead.png^[transformFX^[invert:gb"
))
-- upgrades
if has_upgrades then
if has_mcl_formspec then
table.insert(formspec_base, get_itemslot_bg(margin_x + upgrades_x, margin_y + upgrades_y,1,1))
table.insert(formspec_base, get_itemslot_bg(margin_x + upgrades_x + slot_interval, margin_y + upgrades_y,1,1))
end
table.insert(formspec_base, ("list[context;upgrade1;%.2f,%.2f;1,1;]")
:format(margin_x + upgrades_x, margin_y + upgrades_y))
table.insert(formspec_base, ("list[context;upgrade2;%.2f,%.2f;1,1;]")
:format(margin_x + upgrades_x + slot_interval, margin_y + upgrades_y))
table.insert(formspec_base, ("label[%.2f,%.2f;%s]")
:format(margin_x + upgrades_x, margin_y + upgrades_y + slot_size + label_offset, S("Upgrade Slots")))
end

-- listrings
formspec = formspec..
"listring[context;dst]"..
"listring[current_player;main]"..
"listring[context;src]"..
"listring[current_player;main]"..
(def.upgrade and
"listring[context;upgrade1]"..
"listring[current_player;main]"..
"listring[context;upgrade2]"..
"listring[current_player;main]"
or "")

table.insert(formspec_base, "listring[context;dst]")
table.insert(formspec_base, "listring[current_player;main]")
table.insert(formspec_base, "listring[context;src]")
table.insert(formspec_base, "listring[current_player;main]")
if has_upgrades then
table.insert(formspec_base, "listring[context;upgrade1]")
table.insert(formspec_base, "listring[current_player;main]")
table.insert(formspec_base, "listring[context;upgrade2]")
table.insert(formspec_base, "listring[current_player;main]")
end
table.insert(formspec_base, ("image[%.2f,%.2f;%.2f,%.2f;technic_power_meter_bg.png]")
:format(margin_x + energy_bar_x, margin_y + energy_bar_y, energy_bar_w, energy_bar_h))
table.insert(formspec_base, ("label[%.2f,%.2f;%s]")
:format(margin_x, margin_y, S("@1 Battery Box", S(tier))))
table.insert(formspec_base, ("label[%.2f,%.2f;%s]")
:format(margin_x + energy_bar_x, margin_y + energy_bar_y + energy_bar_h + label_offset, S("Power level")))

formspec_base = table.concat(formspec_base)

--
-- Generate formspec with power meter
--
local function get_formspec(charge_ratio, channel)
return formspec .. "image[1,1;1,2;technic_power_meter_bg.png^[lowpart:" ..
math.floor(charge_ratio * 100) .. ":technic_power_meter_fg.png]" ..
(digilines_path and
("field[0.3,4;2.2,1;channel;"..S("Digiline Channel")..";${channel}]"..
"button[2,3.7;1,1;setchannel;"..S("Save").."]") or "")
local function get_formspec(charge_ratio, current_charge, max_charge)
local formspec = {formspec_base}
table.insert(formspec,
("image[%.2f,%.2f;%.2f,%.2f;technic_power_meter_bg.png^[lowpart:%d:technic_power_meter_fg.png]"):
format(margin_x + energy_bar_x, margin_y + energy_bar_y, energy_bar_w, energy_bar_h, charge_ratio * 100)
)
table.insert(formspec, ("tooltip[%.2f,%.2f;%.2f,%.2f;%s]"):format(
margin_x + energy_bar_x, margin_y + energy_bar_y, energy_bar_w, energy_bar_h,
("%s / %s"):format(technic.EU_string(current_charge), technic.EU_string(max_charge))
))
if has_digilines then
local channel_w, channel_h = 2.5, 0.8
local button_w, button_h = 1, channel_h
local channel_x, channel_y = 0, machine_section_h - channel_h
table.insert(formspec, ("field[%.2f,%.2f;%.2f,%.2f;channel;%s;${channel}]")
:format(margin_x + channel_x, margin_y + channel_y, channel_w, channel_h, S("Digiline Channel")))
table.insert(formspec, ("button[%.2f,%.2f;%.2f,%.2f;setchannel;%s]")
:format(margin_x + channel_x + channel_w, margin_y + channel_y, button_w, button_h, S("Save")))
end
return table.concat(formspec)

end

Expand Down Expand Up @@ -208,8 +300,7 @@ function technic.register_battery_box(nodename, data)
end
meta:set_string("infotext", infotext)
if update_formspec then
local channel = meta:get_string("channel")
meta:set_string("formspec", get_formspec(charge_ratio, channel))
meta:set_string("formspec", get_formspec(charge_ratio, current_charge, max_charge))
end
end

Expand Down
Loading
Loading