Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a blog post announcing the release of mruby 4.0.0, which details significant updates including pattern matching, ROM method tables for reduced memory usage, and various VM and GC optimizations. The review feedback focuses on improving the clarity and flow of the introductory text, ensuring consistency by adding missing reference links to new method entries, and removing a redundant item regarding compiler optimizations.
|
|
||
| We are announcing the first stable release of mruby 4.0 series - [mruby 4.0.0](https://github.com/mruby/mruby/releases/tag/4.0.0). | ||
|
|
||
| Describes the new features and changes in mruby 4.0. |
There was a problem hiding this comment.
The sentence is a fragment. Adding a subject improves the flow and clarity of the introduction.
This post describes the new features and changes in mruby 4.0.
|
|
||
| # User visible changes in `mruby4.0` from `mruby3.4` | ||
|
|
||
| "**_NOTE_**:" are changes to be aware of. |
There was a problem hiding this comment.
The phrasing is a bit awkward. Consider a more descriptive explanation of what the 'NOTE' prefix signifies.
Items marked with "**_NOTE_**:" are significant changes to be aware of.
|
|
||
| - **_NOTE_**: `Hash#deconstruct_keys` removed for CRuby compatibility ([34b9412](https://github.com/mruby/mruby/commit/34b9412)) | ||
| - **mruby-enum-lazy**: Fix `Lazy#flat_map` to handle non-enumerable block return values ([#6765](https://github.com/mruby/mruby/pull/6765)) | ||
| - **mruby-array-ext**: Add `Array#find` and `Array#rfind` methods |
There was a problem hiding this comment.
This entry is missing a reference link (commit or PR), which is inconsistent with the other items in this section. Please add the relevant link if available.
| - **mruby-array-ext**: Add `Array#find` and `Array#rfind` methods | ||
| - **mruby-io**: Add `IO#putc` and `Kernel#putc` ([baff6e6](https://github.com/mruby/mruby/commit/baff6e6)) | ||
| - **mruby-random**: Replace xoshiro with PCG for better memory efficiency ([f1bab01](https://github.com/mruby/mruby/commit/f1bab01)) | ||
| - **mruby-compiler**: Variable-sized AST nodes for reduced memory usage |
There was a problem hiding this comment.
This item is redundant as it is listed again under 'Compiler Improvements' (line 145) with a reference link. Consider removing this duplicate entry.
2 participants
No description provided.