bug 2049040 - Accept 0-duration samples in timing_distribution metrics#3512
Draft
chutten wants to merge 1 commit into
Draft
bug 2049040 - Accept 0-duration samples in timing_distribution metrics#3512chutten wants to merge 1 commit into
chutten wants to merge 1 commit into
Conversation
They go into the underflow bucket. This means a sample of 1 becomes 1x (where x is the time_unit), a duration of 1ns becomes 1x (where x is the time_unit), but a sample of 0 or a duration of 0 remains 0 to count in the 0 (underflow) bucket.
Contributor
Author
|
Another alternative not considered: treating a sample of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They go into the underflow bucket.
This means a sample of 1 becomes 1x (where x is the time_unit), a duration of 1ns is still promoted to 1x (where x is the time_unit), but a sample of 0 or a duration of 0 remains 0 to count in the 0 (underflow) bucket.
(( draft for now because I haven't 1) Added more tests for 0 values for all APIs of all the metrics to make sure our behaviours aren't surprising and don't change out from under us, or 2) thought deeply about the ramifications of reporting counts of zeroes in their special zero buckets. ))
Alternatives not fully considered:
sum, but put it in the bucket for 1x (where x is time_unit) like the rest of the < 1x values