Skip to content

Remove Slack notifications from deploy/build/test workflows#309

Merged
BrianEstrada merged 2 commits into
mainfrom
remove-slack-notifications
Jun 10, 2026
Merged

Remove Slack notifications from deploy/build/test workflows#309
BrianEstrada merged 2 commits into
mainfrom
remove-slack-notifications

Conversation

@BrianEstrada

@BrianEstrada BrianEstrada commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Stops publishing workflow progress and result updates to Slack across the reusable deploy, build, and test workflows. The changelog still publishes to Slack, and pr-digest.yml and the rollback.yml Slack job are left untouched.

Changes

  • Delete component-initialize.yml, whose only purpose was opening the Slack thread (both steps were Slack-related).
  • Remove the initialize job from all deploy orchestrators (deploy-kotlin, deploy-kotlin-v2, deploy-python, deploy-generic, deploy-generic-v2) and rewire the test/build/deploy needs: and if: conditions accordingly.
  • Remove slack-message-id inputs/outputs and all slack-notifier-cli-action steps from the component and deploy workflows (including the dedicated notify-build-finished job in component-build.yml).
  • Remove SLACK_APP_TOKEN from the component workflows and from deploy-python/deploy-generic/deploy-generic-v2.
  • Keep the changelog-cli-action Slack output (output: slack) in deploy-kotlin and deploy-kotlin-v2; these two workflows retain an optional SLACK_APP_TOKEN secret used solely to publish the changelog to #info-releases.

Breaking change

The component workflows and deploy-python/deploy-generic/deploy-generic-v2 no longer declare SLACK_APP_TOKEN or slack-message-id. Caller repos that still pass either will fail until their callers are updated. Repos calling component-initialize.yml directly will also break. In deploy-kotlin/deploy-kotlin-v2, SLACK_APP_TOKEN is now optional rather than required.

Follow-up (not in this PR)

Docs still reference the secret: SLACK_APP_TOKEN appears in docs/workflow-guide.md, docs/v3-migration-guide.md, and README.md.

Validation

actionlint passes on all edited workflows, confirming syntax and that orchestrators no longer pass inputs/secrets the component workflows do not declare.

Stop publishing workflow progress and result updates to Slack across the
reusable deploy, build, and test workflows. Leaves pr-digest.yml and the
rollback Slack job untouched.

- Delete component-initialize.yml (its only purpose was opening the Slack thread)
- Remove the initialize job from all deploy orchestrators and rewire the
  test/build/deploy needs and if conditions accordingly
- Remove SLACK_APP_TOKEN secrets, slack-message-id inputs/outputs, and all
  slack-notifier-cli-action steps from the component and deploy workflows
- Switch the changelog-cli-action output from slack to console, keeping
  GitHub releases and PR/JIRA comments

BREAKING CHANGE: these reusable workflows no longer declare SLACK_APP_TOKEN
or slack-message-id. Caller repos still passing them will fail until updated.
@BrianEstrada BrianEstrada requested a review from a team as a code owner June 10, 2026 17:59
@BrianEstrada BrianEstrada requested review from tobias0106 and removed request for a team June 10, 2026 17:59
Restore the changelog-cli-action slack output (output: slack, slack-token,
slack-channel) in deploy-kotlin and deploy-kotlin-v2, and re-add an optional
SLACK_APP_TOKEN secret used only for publishing the changelog to #info-releases.
@BrianEstrada BrianEstrada merged commit 6e8bb8d into main Jun 10, 2026
1 check passed
@BrianEstrada BrianEstrada deleted the remove-slack-notifications branch June 10, 2026 18:03
BrianEstrada added a commit that referenced this pull request Jun 11, 2026
PR #309 removed the SLACK_APP_TOKEN secret declaration from deploy-generic,
deploy-generic-v2, and deploy-python. Caller repos that still pass it now fail
workflow validation with "Invalid secret, SLACK_APP_TOKEN is not defined in the
referenced workflow".

Re-declare SLACK_APP_TOKEN as an optional (required: false) secret so existing
callers validate again. The token is not used; a lightweight deprecation-check
job emits a ::warning:: annotation when it's still provided, prompting callers
to remove it.

deploy-kotlin/-v2 already declare it (still used for the changelog) and are
unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants