fix: reports not reporting all possible reports#5933
Open
Dragon-Seeker wants to merge 1 commit intomodrinth:mainfrom
Open
fix: reports not reporting all possible reports#5933Dragon-Seeker wants to merge 1 commit intomodrinth:mainfrom
Dragon-Seeker wants to merge 1 commit intomodrinth:mainfrom
Conversation
Basically, for some reason, Labrinth returns 5 less depending on the amount requested and the offset position, leading to the end of all reports, even if it's not correct. Signed-off-by: Blodhgarm <timekeeperguild@gmail.com>
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, for some reason, Labrinth returns 5 less depending on the amount requested and the offset position, leading to the end of all reports based on the reports page logic, even if it's not correct.
This PR just prevents the check, as it only prevents an extra possible query for reports that are not subdivided by the batch count, and overall seems not that important, as getting all reports matters more