Fix various bugs and leaks across the codebase#411
Merged
Conversation
- Add missing rtol definition in fmi_bouncing_ball_native.py (NameError) - Fix x1 < y0 -> x1 < x0 typo in plot_gui.py zoom logic - Close file handles in ResultCSVTextual and ResultDymolaTextual readers - Store self._file immediately after opening in ResultWriterDymola - Fix trailing os.pathsep in list_to_string - Remove duplicate parse_xml_log import in log/__init__.py - Use cls instead of self in @classmethod get_default_options - Remove dead fp variable in pyfmi/__init__.py - Fix comment typo in diagnostics.py
- Close ZipFile after extraction in core.py - Wrap FMICSAlg.solve() in try/except to ensure simulation_end() on failure - Wrap exception gap after simulation_start() in AssimuloFMIAlg.__init__
PeterMeisrimelModelon
merged commit 137cf4a
into
modelon-community:master
1 check passed
Collaborator
|
Thanks for your continued contributions! Sorry for delay in reviewing these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.