user: GetExecUser: rewrite with parseUserArg, parseGroupArg#231
Open
thaJeztah wants to merge 2 commits into
Open
user: GetExecUser: rewrite with parseUserArg, parseGroupArg#231thaJeztah wants to merge 2 commits into
thaJeztah wants to merge 2 commits into
Conversation
thaJeztah
commented
Jun 30, 2026
thaJeztah
changed the title
There was a problem hiding this comment.
Pull request overview
Refactors GetExecUser to reuse shared parsing/matching helpers for user and group arguments, aligning the implementation approach with prior work done for additional group handling.
Changes:
- Replaces inline numeric/name parsing in
GetExecUserwithparseUserArg/parseGroupArgandmatcheshelpers. - Centralizes
groupArg(and newuserArg) parsing/matching helpers inuser_utils.go.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| user/user.go | Rewrites GetExecUser to use parsed user/group argument helpers for matching and error formatting. |
| user/user_utils.go | Adds userArg and parseUserArg, and moves/extends group parsing helpers to support GetExecUser. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a similar approach as was applied to GetAdditionalGroups in 6eb9f15