chat: Warn about sharing Agent Host debug logs#322017
Open
roblourens wants to merge 1 commit into
Open
Conversation
Show a privacy warning after Agent Host debug logs are successfully exported, with internal users directed to share privately via Slack or microsoft/vscode-internalbacklog.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benibenj
approved these changes
Jun 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a post-export privacy notice to the “Export Agent Host Debug Logs” workflow, with different guidance for internal vs external users, and refines the export services to report whether an export actually completed (vs. user cancellation) so the notice only appears on success.
Changes:
- Change
IAgentHostDebugLogsExportService.save(...)to returnbooleanto distinguish successful exports from cancellation. - Show a privacy message after a successful export, with internal-user-specific guidance based on
IChatEntitlementService.isInternal. - Ensure canceled folder/file dialogs short-circuit without showing the warning.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/electron-browser/actions/exportAgentHostDebugLogsService.ts | Updates native (desktop) export flow to return false on dialog cancel and true on successful zip creation. |
| src/vs/workbench/contrib/chat/browser/actions/exportAgentHostDebugLogsAction.ts | Updates export service contract and browser export implementation; adds post-save privacy notice gated on successful save and internal entitlement. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
+346
to
+348
| notificationService.info(chatEntitlementService.isInternal | ||
| ? localize('exportDebugLogs.privacyWarning.internal', "Note: This log may contain personal information such as auth tokens, file contents, or terminal output. It MUST be shared privately via Slack or in an issue filed on the microsoft/vscode-internalbacklog repo.") | ||
| : localize('exportDebugLogs.privacyWarning', "Note: This log may contain personal information such as auth tokens, file contents, or terminal output. Please consider sharing privately or reviewing the contents carefully before sharing.")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- show a privacy warning after Agent Host debug logs are successfully exported\n- direct internal users to share logs privately via Slack or microsoft/vscode-internalbacklog\n- avoid showing the warning when the export dialog is canceled or saving fails\n\n## Validation\n- npm run typecheck-client\n- npm run valid-layers-check\n- npm run precommit\n\n(Written by Copilot)