Model hover redesign based on feedback#322003
Draft
pwang347 wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the chat model picker hover UI and underlying model metadata so a new “model category/tier” can be surfaced as a tag (e.g. lightweight/versatile/powerful), alongside the existing pricing category.
Changes:
- Adds an optional
categoryfield to language model pricing/metadata (proposed API + internal metadata) and plumbs it through the ext host and Copilot endpoint plumbing. - Redesigns the model hover layout (title tags row + simplified cost table + configurable buttons row).
- Simplifies proposed API proposal typings by removing the unused
version?: numberfrom the exportedallApiProposalstype.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.languageModelPricing.d.ts | Adds proposed API surface for optional model category. |
| src/vs/workbench/contrib/chat/common/languageModels.ts | Extends internal model metadata to include optional category. |
| src/vs/workbench/contrib/chat/browser/widget/media/chat.css | Updates CSS for redesigned model hover layout and cost table. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Implements new hover DOM structure and category tag label mapping. |
| src/vs/workbench/contrib/chat/browser/chatSessions/chatSessionPickerActionItem.ts | Updates hover construction call site after hover API signature change. |
| src/vs/workbench/api/common/extHostLanguageModels.ts | Marshals category through ext host language model metadata. |
| src/vs/platform/extensions/common/extensionsApiProposals.ts | Narrows exported allApiProposals type to { proposal: string }. |
| extensions/copilot/src/platform/networking/common/networking.ts | Adds Copilot-side modelPickerCategory field to endpoint metadata. |
| extensions/copilot/src/platform/endpoint/node/chatEndpoint.ts | Plumbs model_picker_category from model metadata into modelPickerCategory. |
| extensions/copilot/src/platform/endpoint/common/endpointProvider.ts | Extends model API response shape with model_picker_category. |
| extensions/copilot/src/extension/conversation/vscode-node/languageModelAccess.ts | Maps Copilot endpoint modelPickerCategory into VS Code model metadata category. |
Copilot's findings
- Files reviewed: 10/11 changed files
- Comments generated: 2
Comment on lines
221
to
224
| ): IActionListItem<IActionWidgetDropdownAction> { | ||
| const hover = model && openerService | ||
| ? getModelHoverContent(model, openerService, isUBB, onConfigure ? (group) => onConfigure(model, group) : undefined) | ||
| ? getModelHoverContent(model, isUBB, onConfigure ? (group) => onConfigure(model, group) : undefined) | ||
| : undefined; |
| .chat-model-hover-cost-table { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 3px; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.