Skip to content

Disable process.report#321998

Merged
benvillalobos merged 4 commits into
release/1.125from
apparent-sparrow
Jun 19, 2026
Merged

Disable process.report#321998
benvillalobos merged 4 commits into
release/1.125from
apparent-sparrow

Conversation

@alexdima

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings June 18, 2026 21:26
@alexdima alexdima self-assigned this Jun 18, 2026
@alexdima alexdima changed the title Apparent sparrow Disable process.report Jun 18, 2026
deepak1556
deepak1556 previously approved these changes Jun 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

The new import-time Object.defineProperty(process, 'report', …) can throw in some Node configurations and would prevent extension activation without a best-effort guard.

Pull request overview

This PR updates the built-in Copilot Chat extension’s Node-only entrypoint to disable process.report at startup, and bumps the extension version accordingly.

Changes:

  • Add an early side-effect import in the Node extension entry (vscode-node/extension.ts) to disable process.report before other modules load.
  • Introduce disableProcessReport.ts which overrides process.report to undefined.
  • Bump extensions/copilot version from 0.53.0 to 0.53.1 (and update the lockfile).
File summaries
File Description
extensions/copilot/src/extension/extension/vscode-node/extension.ts Imports the new disableProcessReport module first to apply the override early in the Node extension host.
extensions/copilot/src/extension/extension/vscode-node/disableProcessReport.ts Implements the process.report disabling behavior (currently needs a safety guard to avoid activation-time crashes).
extensions/copilot/package.json Version bump to 0.53.1.
extensions/copilot/package-lock.json Lockfile version bump to match 0.53.1.

Copilot's findings

Files not reviewed (1)

  • extensions/copilot/package-lock.json: Generated file
  • Files reviewed: 3/4 changed files
  • Comments generated: 1

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

Comment thread extensions/copilot/src/extension/extension/vscode-node/disableProcessReport.ts Outdated
@deepak1556 deepak1556 dismissed their stale review June 18, 2026 21:37

overriding process.report throws, we just restrict it to process.report.getReport ?

deepak1556
deepak1556 previously approved these changes Jun 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

The current shim sets process.report.getReport to undefined and swallows errors, which can cause runtime failures for callers and should be made safe/explicit.

Copilot's findings

Files not reviewed (1)

  • extensions/copilot/package-lock.json: Generated file
  • Files reviewed: 3/4 changed files
  • Comments generated: 1

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

@vs-code-engineering

vs-code-engineering Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • build/azure-pipelines/product-copilot-recovery.yml

@benvillalobos benvillalobos enabled auto-merge (squash) June 19, 2026 01:07
@benvillalobos benvillalobos disabled auto-merge June 19, 2026 01:15
@benvillalobos benvillalobos merged commit af5c64f into release/1.125 Jun 19, 2026
46 of 55 checks passed
@benvillalobos benvillalobos deleted the apparent-sparrow branch June 19, 2026 01:15
@vs-code-engineering vs-code-engineering Bot added this to the 1.125.0 milestone Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants