Disable process.report#321998
Conversation
There was a problem hiding this comment.
⚠️ Not ready to approve
The new import-time Object.defineProperty(process, 'report', …) can throw in some Node configurations and would prevent extension activation without a best-effort guard.
Pull request overview
This PR updates the built-in Copilot Chat extension’s Node-only entrypoint to disable process.report at startup, and bumps the extension version accordingly.
Changes:
- Add an early side-effect import in the Node extension entry (
vscode-node/extension.ts) to disableprocess.reportbefore other modules load. - Introduce
disableProcessReport.tswhich overridesprocess.reporttoundefined. - Bump
extensions/copilotversion from0.53.0to0.53.1(and update the lockfile).
File summaries
| File | Description |
|---|---|
| extensions/copilot/src/extension/extension/vscode-node/extension.ts | Imports the new disableProcessReport module first to apply the override early in the Node extension host. |
| extensions/copilot/src/extension/extension/vscode-node/disableProcessReport.ts | Implements the process.report disabling behavior (currently needs a safety guard to avoid activation-time crashes). |
| extensions/copilot/package.json | Version bump to 0.53.1. |
| extensions/copilot/package-lock.json | Lockfile version bump to match 0.53.1. |
Copilot's findings
Files not reviewed (1)
- extensions/copilot/package-lock.json: Generated file
- Files reviewed: 3/4 changed files
- Comments generated: 1
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
overriding process.report throws, we just restrict it to process.report.getReport ?
There was a problem hiding this comment.
⚠️ Not ready to approve
The current shim sets process.report.getReport to undefined and swallows errors, which can cause runtime failures for callers and should be made safe/explicit.
Copilot's findings
Files not reviewed (1)
- extensions/copilot/package-lock.json: Generated file
- Files reviewed: 3/4 changed files
- Comments generated: 1
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
No description provided.