fix: handle quoted ID values in /etc/os-release parsing#310792
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: handle quoted ID values in /etc/os-release parsing#310792Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Devcontainer setup fails on Rocky Linux 8.5 because the script uses grep -Eo 'ID=([^"]+)' which only matches unquoted values. Rocky Linux 8.5 uses ID="rocky" (quoted) in /etc/os-release. Fix by sourcing /etc/os-release directly, which lets the shell properly handle both quoted and unquoted values. Fixes microsoft#232159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day
Problem
The
check-requirements-linux.shscript fails to parse/etc/os-releaseon Rocky Linux 8.5 (and potentially other distros that quote their ID values).The script uses:
OS_ID="ubuntu"This regex
ID=([^"]+)only matches unquoted values. However, Rocky Linux 8.5 uses:With quotes, the grep fails to match, resulting in an empty
OS_ID, which causes the script to exit with code 1.Solution
Use POSIX-compliant
. /etc/os-release && echo "$ID"to source the file directly. This approach:ID="rocky") and unquoted (ID=ubuntu) values.notsource)Testing
Verified with simulated Rocky Linux
/etc/os-release(quoted) and Ubuntu/Alpine (unquoted) - all parse correctly.Fixes
Fixes #232159
Thank you for your attention. If there are any issues or suggestions, please leave a comment and I will address them promptly.
Warmly,
RoomWithOutRoof