[python] fix: use azure-http-specs check for spec flavor detection#10554
Open
iscai-msft wants to merge 5 commits intomicrosoft:mainfrom
Open
[python] fix: use azure-http-specs check for spec flavor detection#10554iscai-msft wants to merge 5 commits intomicrosoft:mainfrom
iscai-msft wants to merge 5 commits intomicrosoft:mainfrom
Conversation
spec.includes('azure') falsely matches when the working directory
contains 'azure' (e.g. running from azure-sdk-for-python), causing
all specs to be treated as azure specs and producing incorrect
package names like ..-..-..-@typespec-http-specs-specs-<name>.
Changed to spec.includes('azure-http-specs') which only matches
actual azure spec paths from @azure-tools/azure-http-specs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iscai-msft
requested review from
ChenxiJiang333,
catalinaperalta,
lmazuel,
mccoyp,
msyyc,
swathipil,
tadelesh and
timotheeguerin
as code owners
microsoft-github-policy-service
Bot
added
the
emitter:client:python
Merge regenerate-common.ts into regenerate.ts since it had only one
consumer. Also fix spec.includes('azure') which falsely matched when
the working directory contained 'azure' (e.g. azure-sdk-for-python),
causing incorrect package names for unbranded specs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
commit: |
Collaborator
|
You can try these changes here
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
All changed packages have been documented.
Show changes
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec.includes('azure') falsely matches when the working directory contains 'azure' (e.g. running from azure-sdk-for-python), causing all specs to be treated as azure specs and producing incorrect package names like ..-..-..-@typespec-http-specs-specs-.
Changed to spec.includes('azure-http-specs') which only matches actual azure spec paths from @azure-tools/azure-http-specs.