Remove duplicate IsTypeReachableFromGeneratedCode in TestClassModelBuilder#9473
Draft
Copilot wants to merge 2 commits into
Draft
Remove duplicate IsTypeReachableFromGeneratedCode in TestClassModelBuilder#9473Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix duplicate code in TestClassModelBuilder
Remove duplicate IsTypeReachableFromGeneratedCode in TestClassModelBuilder
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestClassModelBuilder.IsTypeReachableFromGeneratedCodewas a semantic duplicate ofSymbolAccessibilityHelper.IsAccessibleFromGeneratedCode, which is already linked into the same project and used by the siblingMSTestReflectionMetadataGenerator.Changes
IsTypeReachableFromGeneratedCodefromTestClassModelBuilder.csSymbolAccessibilityHelper.IsAccessibleFromGeneratedCodeNo project file changes needed —
SymbolAccessibilityHelper.csis already referenced via<Compile Include="..\Shared\SymbolAccessibilityHelper.cs" />andusing MSTest.Analyzers.Shared;was already present.The two implementations were semantically equivalent across all
Accessibilityvalues; they differed only in allow-list vs. deny-list style. The shared helper is the canonical version and explicitly handlesNotApplicable(which the duplicate only allowed implicitly).