[0.84] Fix touch event handling, improve reliability, and optimize performan… by acoates-ms · Pull Request #16058 · microsoft/react-native-windows

acoates-ms · 2026-04-27T16:16:29Z

Port #16048 to 0.84

Microsoft Reviewers: Open in CodeFlow

…ce (microsoft#16048) * Fix touch event handling, improve reliability, and optimize performance - Fix touch/pen pointer device type detection and screenPoint coordinates - Fix touch cancel to include all active touches per W3C spec - Synthesize touch-cancel for stale pointers and releases outside views - Fix TextInput pointer message translation (use mouse-style messages for RichEdit) - Fix ShouldSubmit modifier key checks (altDown, ctrlKey) - Add null safety to RootComponentView() for island teardown - Fix Pressability hover timeout and tabIndex focusable mapping - Cache event path to root to avoid repeated tree walks - Use unordered_set for pointer capture tracking - Eliminate O(n²) hit testing by caching visual children - Skip snap scroll reconfiguration when unchanged - Improve TextInput reliability: thread-safe loading, null safety, use-after-free fix - Fix Timing data race and remove duplicate image error allocation - Use unordered_set for animated node and component registry lookups - Clean up dead code in ScrollView and simplify Modal event emitter init * formatting * Change files * Update react-native-windows-cd995d7a-4df8-4c73-9b1b-c57b3b886cc6.json * Touch target * addressed pr comments * Crash on invalid index * revert until rn core pr * Update react-native-windows-cd995d7a-4df8-4c73-9b1b-c57b3b886cc6.json * format * snapshots --------- Co-authored-by: Gordon MacMaster <31481849+gmacmaster@users.noreply.github.com> Co-authored-by: Gordon MacMaster <gordomacmaster@gmail.com>

github-actions · 2026-04-27T16:46:43Z

Performance Test Results

Branch: cherrytouch84
Commit: 5cad033a
Time: 2026-04-27T16:42:16.262Z
Tests: 161/161 passed

✅ Passed

161 scenario(s) across 28 suite(s) — no regressions

SectionList

Scenario	Mean	Median	StdDev	Renders	vs Baseline
SectionList mount	4.10ms	4.00ms	±0.57ms	1	-20.0%
SectionList unmount	0.10ms	0.00ms	±0.32ms	0	+0.0%
SectionList rerender	11.20ms	12.00ms	±1.75ms	2	+14.3%
SectionList with-3-sections-15-items	6.20ms	6.50ms	±1.14ms	1	+18.2%
SectionList with-5-sections-50-items	5.40ms	5.00ms	±1.07ms	1	-16.7%
SectionList with-10-sections-200-items	5.70ms	5.00ms	±2.75ms	1	-9.1%
SectionList with-20-sections-200-items	4.40ms	5.00ms	±1.35ms	1	+0.0%
SectionList with-section-separator	1.90ms	2.00ms	±0.74ms	1	+0.0%
SectionList with-item-separator	2.60ms	2.50ms	±0.70ms	1	+25.0%
SectionList with-header-footer	1.50ms	1.50ms	±0.53ms	1	-25.0%
SectionList with-section-footer	1.70ms	2.00ms	±0.67ms	1	+0.0%
SectionList with-sticky-section-headers	1.70ms	1.50ms	±0.95ms	1	-25.0%
SectionList with-empty-list	0.40ms	0.00ms	±0.52ms	1	-100.0%
SectionList with-50-sections-1000-items	1.60ms	2.00ms	±0.52ms	1	+0.0%

FlatList

Scenario	Mean	Median	StdDev	Renders	vs Baseline
FlatList mount	4.10ms	4.00ms	±0.32ms	1	+0.0%
FlatList unmount	0.10ms	0.00ms	±0.32ms	0	+0.0%
FlatList rerender	10.20ms	9.00ms	±3.26ms	2	+0.0%
FlatList with-10-items	4.20ms	4.00ms	±0.79ms	1	+0.0%
FlatList with-100-items	4.30ms	4.00ms	±0.67ms	1	-20.0%
FlatList with-500-items	5.40ms	6.00ms	±1.07ms	1	+50.0%
FlatList with-1000-items	3.90ms	4.00ms	±0.57ms	1	+0.0%
FlatList horizontal	3.70ms	4.00ms	±1.25ms	1	-20.0%
FlatList with-separator	2.30ms	2.00ms	±0.67ms	1	+0.0%
FlatList with-header-footer	1.40ms	1.00ms	±0.52ms	1	-50.0%
FlatList with-empty-list	0.20ms	0.00ms	±0.42ms	1	-100.0%
FlatList with-get-item-layout	1.80ms	2.00ms	±0.42ms	1	+100.0%
FlatList inverted	1.90ms	2.00ms	±0.32ms	1	+33.3%
FlatList with-num-columns	2.90ms	2.50ms	±1.52ms	1	-16.7%

TouchableOpacity

Scenario	Mean	Median	StdDev	Renders	vs Baseline
TouchableOpacity mount	0.80ms	1.00ms	±0.42ms	1	+0.0%
TouchableOpacity unmount	0.10ms	0.00ms	±0.32ms	0	+0.0%
TouchableOpacity rerender	1.20ms	1.00ms	±1.40ms	2	+0.0%
TouchableOpacity custom-active-opacity	0.40ms	0.00ms	±0.52ms	1	-100.0%
TouchableOpacity disabled	0.60ms	1.00ms	±0.52ms	1	+0.0%
TouchableOpacity with-all-handlers	0.60ms	1.00ms	±0.52ms	1	+0.0%
TouchableOpacity with-hit-slop	1.00ms	1.00ms	±0.00ms	1	+0.0%
TouchableOpacity with-delay	0.80ms	1.00ms	±0.42ms	1	+0.0%
TouchableOpacity nested	1.20ms	1.00ms	±0.42ms	1	+0.0%
TouchableOpacity multiple-10	6.27ms	6.00ms	±2.09ms	1	+0.0%
TouchableOpacity multiple-50	25.60ms	25.00ms	±4.63ms	1	-13.8%
TouchableOpacity multiple-100	31.67ms	33.00ms	±10.88ms	1	-34.0%

ScrollView

Scenario	Mean	Median	StdDev	Renders	vs Baseline
ScrollView mount	1.00ms	1.00ms	±1.49ms	1	+Infinity%
ScrollView unmount	0.00ms	0.00ms	±0.00ms	0	+0.0%
ScrollView rerender	0.50ms	0.50ms	±0.53ms	2	-50.0%
ScrollView children-20	2.80ms	3.00ms	±0.68ms	1	-25.0%
ScrollView children-100	15.60ms	15.00ms	±3.07ms	1	-6.3%
ScrollView horizontal	2.90ms	3.00ms	±0.57ms	1	-25.0%
ScrollView sticky-headers	2.60ms	3.00ms	±0.84ms	1	+0.0%
ScrollView scroll-indicators	0.90ms	1.00ms	±0.32ms	1	+0.0%
ScrollView nested	1.70ms	2.00ms	±0.67ms	1	+100.0%
ScrollView content-container-style	0.50ms	0.50ms	±0.53ms	1	-50.0%
ScrollView children-500	20.93ms	19.00ms	±4.79ms	1	+0.0%

TouchableHighlight

Scenario	Mean	Median	StdDev	Renders	vs Baseline
TouchableHighlight mount	0.50ms	0.50ms	±0.53ms	1	+0.0%
TouchableHighlight unmount	0.00ms	0.00ms	±0.00ms	0	+0.0%
TouchableHighlight rerender	0.50ms	0.50ms	±0.53ms	2	-50.0%
TouchableHighlight custom-underlay-color	1.00ms	1.00ms	±1.49ms	1	+Infinity%
TouchableHighlight custom-active-opacity	0.50ms	0.50ms	±0.53ms	1	+Infinity%
TouchableHighlight disabled	0.30ms	0.00ms	±0.48ms	1	+0.0%
TouchableHighlight with-all-handlers	0.20ms	0.00ms	±0.42ms	1	+0.0%
TouchableHighlight with-hit-slop	0.30ms	0.00ms	±0.48ms	1	+0.0%
TouchableHighlight nested-touchables	0.80ms	1.00ms	±0.42ms	1	+0.0%
TouchableHighlight multiple-touchables-10	2.40ms	2.00ms	±0.52ms	1	-33.3%
TouchableHighlight multiple-touchables-50	12.30ms	12.50ms	±2.11ms	1	+0.0%
TouchableHighlight multiple-touchables-100	23.60ms	23.00ms	±4.67ms	1	+2.2%

Pressable

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Pressable mount	0.30ms	0.00ms	±0.48ms	1	+0.0%
Pressable unmount	0.00ms	0.00ms	±0.00ms	0	+0.0%
Pressable rerender	0.50ms	0.50ms	±0.53ms	2	+0.0%
Pressable with-all-handlers	0.20ms	0.00ms	±0.42ms	1	+0.0%
Pressable with-style-function	0.30ms	0.00ms	±0.48ms	1	+0.0%
Pressable disabled	0.20ms	0.00ms	±0.42ms	1	+0.0%
Pressable with-hit-slop	0.30ms	0.00ms	±0.48ms	1	+0.0%
Pressable nested	0.50ms	0.50ms	±0.53ms	1	-50.0%
Pressable multiple-10	2.53ms	3.00ms	±0.52ms	1	+0.0%
Pressable multiple-50	15.73ms	15.00ms	±3.01ms	1	+7.1%
Pressable multiple-100	17.67ms	13.00ms	±10.49ms	1	+8.3%

Modal

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Modal mount	0.20ms	0.00ms	±0.42ms	1	+0.0%
Modal unmount	0.10ms	0.00ms	±0.32ms	0	+0.0%
Modal rerender	0.30ms	0.00ms	±0.48ms	2	+0.0%
Modal slide-animation	0.50ms	0.50ms	±0.53ms	1	+Infinity%
Modal fade-animation	0.40ms	0.00ms	±0.52ms	1	+0.0%
Modal transparent	0.40ms	0.00ms	±0.52ms	1	+0.0%
Modal with-callbacks	0.50ms	0.50ms	±0.53ms	1	+Infinity%
Modal rich-content	3.10ms	3.00ms	±0.32ms	1	+50.0%
Modal with-accessibility	0.70ms	1.00ms	±0.48ms	1	+Infinity%

Image

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Image mount	0.20ms	0.00ms	±0.42ms	1	+0.0%
Image unmount	0.00ms	0.00ms	±0.00ms	0	+0.0%
Image rerender	0.10ms	0.00ms	±0.32ms	2	+0.0%
Image with-resize-mode	0.20ms	0.00ms	±0.42ms	1	+0.0%
Image with-border-radius	0.10ms	0.00ms	±0.32ms	1	+0.0%
Image with-tint-color	0.10ms	0.00ms	±0.32ms	1	+0.0%
Image with-blur-radius	0.10ms	0.00ms	±0.32ms	1	+0.0%
Image with-accessibility	0.10ms	0.00ms	±0.32ms	1	+0.0%
Image multiple-10	0.87ms	1.00ms	±0.35ms	1	+0.0%
Image multiple-50	3.33ms	3.00ms	±0.72ms	1	+0.0%
Image multiple-100	7.40ms	7.00ms	±1.30ms	1	-12.5%

ActivityIndicator

Scenario	Mean	Median	StdDev	Renders	vs Baseline
ActivityIndicator mount	0.10ms	0.00ms	±0.32ms	1	+0.0%
ActivityIndicator unmount	0.00ms	0.00ms	±0.00ms	0	+0.0%
ActivityIndicator rerender	0.10ms	0.00ms	±0.32ms	2	+0.0%
ActivityIndicator size-large	0.10ms	0.00ms	±0.32ms	1	+0.0%
ActivityIndicator size-small	0.10ms	0.00ms	±0.32ms	1	+0.0%
ActivityIndicator with-color	0.20ms	0.00ms	±0.42ms	1	+0.0%
ActivityIndicator not-animating	0.10ms	0.00ms	±0.32ms	1	+0.0%
ActivityIndicator with-accessibility	0.10ms	0.00ms	±0.32ms	1	+0.0%
ActivityIndicator multiple-10	0.87ms	1.00ms	±0.35ms	1	+0.0%
ActivityIndicator multiple-50	3.80ms	4.00ms	±1.08ms	1	+0.0%
ActivityIndicator multiple-100	7.67ms	7.00ms	±1.50ms	1	+0.0%

Switch

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Switch mount	0.20ms	0.00ms	±0.42ms	1	+0.0%
Switch unmount	0.00ms	0.00ms	±0.00ms	0	+0.0%
Switch rerender	0.20ms	0.00ms	±0.42ms	2	-100.0%
Switch value-true	0.10ms	0.00ms	±0.32ms	1	+0.0%
Switch disabled	0.30ms	0.00ms	±0.48ms	1	+0.0%
Switch custom-colors	0.40ms	0.00ms	±0.52ms	1	+0.0%
Switch on-value-change	0.20ms	0.00ms	±0.42ms	1	+0.0%
Switch with-accessibility	0.30ms	0.00ms	±0.48ms	1	+0.0%
Switch multiple-10	1.33ms	1.00ms	±0.49ms	1	-50.0%
Switch multiple-50	9.73ms	8.00ms	±4.17ms	1	-11.1%
Switch multiple-100	18.60ms	18.00ms	±4.19ms	1	+12.5%

Button

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Button mount	0.60ms	1.00ms	±0.52ms	1	+0.0%
Button unmount	0.00ms	0.00ms	±0.00ms	0	+0.0%
Button rerender	1.00ms	1.00ms	±0.00ms	2	+0.0%
Button disabled	1.00ms	1.00ms	±1.49ms	1	+0.0%
Button with-color	0.80ms	1.00ms	±0.42ms	1	+100.0%
Button with-accessibility	0.50ms	0.50ms	±0.53ms	1	-50.0%
Button multiple-10	5.00ms	5.00ms	±1.07ms	1	-16.7%
Button multiple-50	20.07ms	23.00ms	±7.97ms	1	-14.8%
Button multiple-100	15.40ms	14.00ms	±4.60ms	1	-26.3%

TextInput

Scenario	Mean	Median	StdDev	Renders	vs Baseline
TextInput mount	0.20ms	0.00ms	±0.42ms	1	+0.0%
TextInput unmount	0.00ms	0.00ms	±0.00ms	0	+0.0%
TextInput rerender	0.00ms	0.00ms	±0.00ms	2	+0.0%
TextInput multiline	0.10ms	0.00ms	±0.32ms	1	+0.0%
TextInput with-value	0.10ms	0.00ms	±0.32ms	1	+0.0%
TextInput styled	0.00ms	0.00ms	±0.00ms	1	+0.0%
TextInput multiple-100	7.93ms	7.00ms	±1.98ms	1	+0.0%

View

Scenario	Mean	Median	StdDev	Renders	vs Baseline
View mount	0.20ms	0.00ms	±0.42ms	1	+0.0%
View unmount	0.00ms	0.00ms	±0.00ms	0	+0.0%
View rerender	0.10ms	0.00ms	±0.32ms	2	+0.0%
View nested-50	3.53ms	3.00ms	±1.41ms	1	+0.0%
View nested-100	7.33ms	7.00ms	±1.63ms	1	+0.0%
View shadow	0.20ms	0.00ms	±0.42ms	1	+0.0%
View border-radius	0.10ms	0.00ms	±0.32ms	1	+0.0%
View nested-500	17.67ms	10.00ms	±13.50ms	1	+0.0%

Text

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Text mount	0.20ms	0.00ms	±0.42ms	1	+0.0%
Text unmount	0.00ms	0.00ms	±0.00ms	0	+0.0%
Text rerender	0.20ms	0.00ms	±0.42ms	2	+0.0%
Text long-1000	0.20ms	0.00ms	±0.42ms	1	+0.0%
Text nested	0.20ms	0.00ms	±0.42ms	1	+0.0%
Text styled	0.10ms	0.00ms	±0.32ms	1	+0.0%
Text multiple-100	7.73ms	7.00ms	±2.02ms	1	+0.0%

SectionList.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
SectionList native mount	6.28ms	5.78ms	±1.26ms	1	-11.2%

FlatList.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
FlatList native mount	6.22ms	6.48ms	±0.82ms	1	-29.8%

TouchableHighlight.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
TouchableHighlight native mount	1.93ms	1.81ms	±0.26ms	1	-13.3%

TouchableOpacity.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
TouchableOpacity native mount	2.56ms	2.37ms	±0.91ms	1	-24.4%

Pressable.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Pressable native mount	1.78ms	1.74ms	±0.12ms	1	-30.6%

ScrollView.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
ScrollView native mount	3.79ms	3.78ms	±0.40ms	1	-6.7%

ActivityIndicator.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
ActivityIndicator native mount	2.00ms	1.68ms	±0.82ms	1	-32.5%

TextInput.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
TextInput native mount	2.27ms	2.12ms	±0.29ms	1	-48.1%

Switch.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Switch native mount	1.57ms	1.46ms	±0.47ms	1	-16.0%

Button.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Button native mount	2.83ms	2.49ms	±1.59ms	1	-4.2%

Modal.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Modal native mount	1.20ms	1.08ms	±0.25ms	1	-11.4%

Image.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Image native mount	1.78ms	1.74ms	±0.22ms	1	-23.0%

View.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
View native mount	1.50ms	1.34ms	±0.56ms	1	-6.4%

Text.native-perf-test.ts

Scenario	Mean	Median	StdDev	Renders	vs Baseline
Text native mount	1.57ms	1.53ms	±0.16ms	1	-11.9%

acoates-ms requested a review from a team as a code owner April 27, 2026 16:16

acoates-ms merged commit 91ceaa8 into microsoft:0.84-stable Apr 27, 2026
39 checks passed

acoates-ms deleted the cherrytouch84 branch April 27, 2026 20:12

Conversation

acoates-ms commented Apr 27, 2026 • edited by microsoft-github-policy-service Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Microsoft Reviewers: Open in CodeFlow

Uh oh!

github-actions Bot commented Apr 27, 2026

Performance Test Results

✅ Passed

SectionList

FlatList

TouchableOpacity

ScrollView

TouchableHighlight

Pressable

Modal

Image

ActivityIndicator

Switch

Button

TextInput

View

Text

SectionList.native-perf-test.ts

FlatList.native-perf-test.ts

TouchableHighlight.native-perf-test.ts

TouchableOpacity.native-perf-test.ts

Pressable.native-perf-test.ts

ScrollView.native-perf-test.ts

ActivityIndicator.native-perf-test.ts

TextInput.native-perf-test.ts

Switch.native-perf-test.ts

Button.native-perf-test.ts

Modal.native-perf-test.ts

Image.native-perf-test.ts

View.native-perf-test.ts

Text.native-perf-test.ts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

acoates-ms commented Apr 27, 2026 •

edited by microsoft-github-policy-service Bot

Loading