fix: ensure time is logged even when exception is raised in logt()#2194
Open
AHS0003 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: ensure time is logged even when exception is raised in logt()#2194AHS0003 wants to merge 1 commit intomicrosoft:mainfrom
AHS0003 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
logtcontext manager inqlib/log.pyplaceslog_cost_timeoutside thetry/finallyblock. This means if an exception is raised inside awith TimeInspector.logt():block, the time is never logged and the time mark pushed onto the stack is never popped, causing a stack leak.How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Types of changes