chore(cli): migrate dashboard to playwright protocol#40143
Open
Skn0tt wants to merge 2 commits intomicrosoft:mainfrom
Open
chore(cli): migrate dashboard to playwright protocol#40143Skn0tt wants to merge 2 commits intomicrosoft:mainfrom
Skn0tt wants to merge 2 commits intomicrosoft:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Apr 10, 2026
Collaborator
There was a problem hiding this comment.
Why is this called cli.ts?
Member
Author
There was a problem hiding this comment.
renamed it to dashboardBundle.ts to align with our naming
| entryPoints: [ | ||
| filePath('packages/playwright-client/src/cli.ts'), | ||
| ], | ||
| outfile: filePath('packages/playwright-core/lib/clientBundle.js'), |
Collaborator
There was a problem hiding this comment.
Don't we need an entry in package.json to be able to require this?
Member
Author
There was a problem hiding this comment.
No, because we don't require it. We fs.readFile it.
| onclose?: (cause?: string) => void; | ||
| } | ||
|
|
||
| // this entrypoint is used between dashboard and playwright-cli. |
Collaborator
There was a problem hiding this comment.
- I don't think this comment is too useful. Better explain this is the entry point to the client bundle.
- Why not use
playwright.chromium.connect()? - Should we also pass a
platforminstance?
Member
Author
There was a problem hiding this comment.
updated the comment. we can't use playwright.chromium.connect because it won't use the browser's websocket impl. I don't think we should pass the platform instance so it's easier to maintain cross-version compatibility
Skn0tt
force-pushed
the
dashboard-pw-client
branch
from
fbd4c64 to
7b2512b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Skn0tt
force-pushed
the
dashboard-pw-client
branch
from
9a64e0c to
981d904
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"1 failed 5986 passed, 916 skipped Merge workflow run. |
Contributor
Test results for "tests 1"10 flaky39173 passed, 847 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.