Skip to content

CHORE: Add Rust Changes section to PR template for mssql-py-core version bumps#544

Open
gargsaumya wants to merge 3 commits intomainfrom
saumya/rust-release-notes
Open

CHORE: Add Rust Changes section to PR template for mssql-py-core version bumps#544
gargsaumya wants to merge 3 commits intomainfrom
saumya/rust-release-notes

Conversation

@gargsaumya
Copy link
Copy Markdown
Contributor

@gargsaumya gargsaumya commented Apr 28, 2026

Work Item / Issue Reference

GitHub Issue: N/A
AB#44644


Summary

Adds a structured ## Rust Changes\ comment block to the PR template. This block is only relevant for PRs that bump `eng/versions/mssql-py-core.version`.

When a version bump PR is raised, the author deletes the comment wrapper and fills in categorised customer-facing changes (Features / Bug Fixes / Performance) from the Rust side. This makes the information available in the Python repo PR history so the Release Manager can auto-extract it at release time — eliminating the manual step of separately gathering Rust changes during the release process.

What changes

  • Added a ## Rust Changes (mssql-py-core X.X.X → X.X.X)\ comment block under the Summary section
  • Block is ignored by all non-version-bump PRs (it stays as a comment)
  • Version bump PR authors fill it in as part of their PR

Copilot AI review requested due to automatic review settings April 28, 2026 07:59
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a structured, commented “Rust Changes” block to the GitHub PR template so version-bump PRs for eng/versions/mssql-py-core.version can include customer-facing Rust-side release notes in a consistent, extractable format.

Changes:

  • Inserted an HTML-commented “MSSQL-PY-CORE VERSION BUMP ONLY” instructions block under the Summary section.
  • Added a “## Rust Changes (mssql-py-core X.X.X → X.X.X)” skeleton with Features / Bug Fixes / Performance subsections.
  • Included guidance for what to include/exclude and how to link Rust PRs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/PULL_REQUEST_TEMPLATE.MD Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

📊 Code Coverage Report

🔥 Diff Coverage

100%


🎯 Overall Coverage

79%


📈 Total Lines Covered: 6860 out of 8636
📁 Project: mssql-python


Diff Coverage

Diff: main...HEAD, staged and unstaged changes

No lines with coverage information in this diff.


📋 Files Needing Attention

📉 Files with overall lowest coverage (click to expand)
mssql_python.pybind.logger_bridge.cpp: 59.2%
mssql_python.pybind.ddbc_bindings.h: 67.9%
mssql_python.row.py: 70.5%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 74.6%
mssql_python.pybind.connection.connection.cpp: 76.2%
mssql_python.__init__.py: 77.3%
mssql_python.ddbc_bindings.py: 79.6%
mssql_python.pybind.connection.connection_pool.cpp: 79.6%
mssql_python.connection.py: 85.3%

🔗 Quick Links

⚙️ Build Summary 📋 Coverage Details

View Azure DevOps Build

Browse Full Coverage Report

@github-actions github-actions Bot added the pr-size: small Minimal code update label Apr 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- **Improvement name** — One sentence: what got faster/lighter and in which scenario.

> Tip: omit internal Rust refactors, CI-only changes, and test-only changes.
> Link Rust PRs using full URL: https://github.com/microsoft/mssql-rs/pull/N
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not been sending Rust PRs in OSS. This is not applicable right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-size: small Minimal code update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants