Skip to content

FIX: Release GIL around blocking ODBC statement, fetch, and transaction calls (#540) #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saurabh500 merged 8 commits into from
Apr 29, 2026
+413 −51
Merged

FIX: Release GIL around blocking ODBC statement, fetch, and transaction calls (#540) #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d35b100
Release GIL around blocking ODBC statement calls (#540)
saurabh500 Apr 24, 2026
739d11f
FIX: Give each reader thread its own connection in test_lowercase_con…
saurabh500 Apr 27, 2026
21f07f3
CHORE: Strip '(issue #540).' from GIL-release comments in ddbc_bindin…
saurabh500 Apr 27, 2026
19c8fe3
TEST: Add functional GIL-release tests for cursor.execute and commit
saurabh500 Apr 27, 2026
cd264c9
STYLE: black --line-length=100 on test_022_concurrent_query_gil_release
saurabh500 Apr 27, 2026
1747338
test: stabilize commit-after-WAITFOR heartbeat test on macOS
saurabh500 Apr 28, 2026
0e4a109
Merge branch 'main' into dev/saurabh/gilrelease
saurabh500 Apr 28, 2026
8cab66d
Merge branch 'main' into dev/saurabh/gilrelease
saurabh500 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions mssql_python/pybind/connection/connection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,12 @@ void Connection::commit() {
}
updateLastUsed();
LOG("Committing transaction");
SQLRETURN ret = SQLEndTran_ptr(SQL_HANDLE_DBC, _dbcHandle->get(), SQL_COMMIT);
SQLRETURN ret;
{
// Release the GIL during the blocking SQLEndTran network round-trip.
py::gil_scoped_release release;
ret = SQLEndTran_ptr(SQL_HANDLE_DBC, _dbcHandle->get(), SQL_COMMIT);
}
checkError(ret);
}

Expand All @@ -201,7 +206,12 @@ void Connection::rollback() {
}
updateLastUsed();
LOG("Rolling back transaction");
SQLRETURN ret = SQLEndTran_ptr(SQL_HANDLE_DBC, _dbcHandle->get(), SQL_ROLLBACK);
SQLRETURN ret;
{
// Release the GIL during the blocking SQLEndTran network round-trip.
py::gil_scoped_release release;
ret = SQLEndTran_ptr(SQL_HANDLE_DBC, _dbcHandle->get(), SQL_ROLLBACK);
}
checkError(ret);
}

Expand Down
Loading
Loading