[live-migration]: add sandbox_id to ImportSandboxRequest rpc#2702
Merged
rawahars merged 1 commit intomicrosoft:mainfrom Apr 23, 2026
Merged
[live-migration]: add sandbox_id to ImportSandboxRequest rpc#2702rawahars merged 1 commit intomicrosoft:mainfrom
rawahars merged 1 commit intomicrosoft:mainfrom
Conversation
The destination shim is created by the ImportSandbox RPC itself, so there is no prior channel through which the caller can communicate the new sandbox id. This change adds a sandbox_id field to ImportSandboxRequest so the opaque config exported from the source can be rehydrated into a new sandbox with the caller-supplied id on the destination. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
apurv15
approved these changes
Apr 23, 2026
jterry75
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The destination shim is created by the
ImportSandboxRPC itself, so there is no prior channel through which the caller can communicate the newsandbox id. This change adds asandbox_idfield toImportSandboxRequestso the opaque config exported from the source can be rehydrated into a new sandbox with the caller-supplied id on the destination.