parity: add LCOW document permutation tests#2631
Open
shreyanshjain7174 wants to merge 1 commit intomicrosoft:mainfrom
Open
parity: add LCOW document permutation tests#2631shreyanshjain7174 wants to merge 1 commit intomicrosoft:mainfrom
shreyanshjain7174 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
shreyanshjain7174
force-pushed
the
parity/lcow-permutations
branch
from
6a7f064 to
917d728
Compare
shreyanshjain7174
force-pushed
the
parity/lcow-permutations
branch
from
917d728 to
c24edac
Compare
shreyanshjain7174
force-pushed
the
parity/lcow-permutations
branch
3 times, most recently
from
f71836c to
412dd22
Compare
shreyanshjain7174
force-pushed
the
parity/lcow-permutations
branch
4 times, most recently
from
4d1c035 to
a72d5b1
Compare
shreyanshjain7174
force-pushed
the
parity/lcow-permutations
branch
from
a72d5b1 to
f31ad7d
Compare
anmaxvl
reviewed
Apr 15, 2026
| func isOnlyKernelCmdLineWhitespaceDiff(legacy, v2 *hcsschema.ComputeSystem) bool { | ||
| legacyCopy := *legacy | ||
| v2Copy := *v2 | ||
| if legacyCopy.VirtualMachine != nil { |
Contributor
There was a problem hiding this comment.
this could've been a helper, that returns a copy. also, can't we just json marshal/unmarshal?
rawahars
added this to the
[shim V2] Adds the V2 shim for Linux containers on Windows milestone
shreyanshjain7174
force-pushed
the
parity/lcow-permutations
branch
from
f31ad7d to
17e6869
Compare
Add permutation tests exercising annotation and option combinations that trigger different document construction branches in the legacy and v2 pipelines. Permutation tests cover: CPU partial combinations (count-only, limit-only, weight-only), memory (overcommit disabled, cold discard hint, deferred commit, non-aligned size), boot mode (kernel direct + VHD rootfs, UEFI, UEFI + VHD), feature flags (scratch encryption + disabled writable shares, writable overlay dirs, policy-based routing), cross-group interactions (physically backed + scratch encryption, full CPU + memory + MMIO + QoS + cold discard + VHD boot), shim option overrides (annotation CPU/memory overriding shim option values, default container annotations), kernel args (VPCI + custom boot options, time sync + process dump + writable overlay, initrd boot whitespace quirk, dump directory path), HvSocket (extra VSock ports). Error path tests verify both pipelines reject the same invalid inputs. Non-default sandbox options tests verify SandboxOptions field parity when annotations set non-default values. Gap tests document known v2 builder differences using inverted assertions (shim log level propagation, console pipe formatting). Add normalizeKernelCmdLine and deepCopyDoc (JSON round-trip) helpers for whitespace-only diff detection. Signed-off-by: Shreyanshjain7174 <shreyanshjain7174@gmail.com> Signed-off-by: Shreyansh Sancheti <shsancheti@microsoft.com>
shreyanshjain7174
force-pushed
the
parity/lcow-permutations
branch
from
17e6869 to
8e06a52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the LCOW parity test infrastructure from #2629 with permutation tests that exercise annotation and option combinations triggering different document construction branches in the legacy and v2 pipelines.
19 permutation tests covering: CPU partial combinations (count-only, limit-only, weight-only), memory (overcommit disabled, cold discard hint), boot mode (kernel direct + VHD rootfs), feature flags (scratch encryption + disabled writable shares, writable overlay dirs), device interactions (VPMem disabled triggers 4 SCSI controllers), cross-group (physically backed + VPMem disabled + scratch encryption, full CPU + memory + MMIO + QoS + cold discard + VHD boot), shim option overrides (annotation CPU/memory overriding shim option values), kernel args (VPCIEnabled + custom boot options, time sync + process dump + writable overlay, initrd boot whitespace quirk).
3 gap tests documenting known v2 builder differences using inverted assertions — they expect a diff and fail only if documents unexpectedly match: nil vs empty CpuGroup, nil vs empty StorageQoS, VPMem controller allocation on initrd boot.
Added
normalizeKernelCmdLineandisOnlyKernelCmdLineWhitespaceDiffhelpers. The legacy builder produces a leading space in kernel command lines for initrd+KernelDirect boot that the v2 builder correctly omits. Since HCS trims whitespace, we warn instead of failing.