Qualify auto-generated sub-orchestration IDs across continue_as_new generations#33
Open
Copilot wants to merge 2 commits into
Open
Qualify auto-generated sub-orchestration IDs across continue_as_new generations#33Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix collision of auto-generated sub-orchestration IDs
Qualify auto-generated sub-orchestration IDs across continue_as_new generations
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auto-generated sub-orchestration IDs were based only on
event_id; aftercontinue_as_new,event_idrestarts and children could reuse prior-generation IDs, stalling parent waits against already-completed child instances.This change makes auto IDs generation-qualified for execution
N>1while keeping execution 1 format unchanged for compatibility.Runtime ID derivation
sub::{event_id}sub::{execution_id}.{event_id}Replay-engine regression coverage
sub::2.{event_id}for auto-generated child IDs.Docs
Checklist
cargo nt)cargo test --doc --all-features)docs/if introducing a new areadocs/README.mdLinks / Design notes
src/runtime/replay_engine.rs(auto ID resolution now includesexecution_id)tests/replay_engine/sub_orchestration.rs(new generation-specific ID test)docs/sub-orchestrations.mddocs/replay-engine-test-spec.md