test(integration): add live GitLab generic install smoke#1663
Open
abhinavgautam01 wants to merge 2 commits into
Open
test(integration): add live GitLab generic install smoke#1663abhinavgautam01 wants to merge 2 commits into
abhinavgautam01 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a scheduled/manual live smoke test to validate that apm install can clone and lock a real GitLab-hosted package via the generic git backend.
Changes:
- Introduces a new live integration test that installs a configured GitLab repo and asserts lockfile stamping with a full commit SHA.
- Registers a new
live_genericpytest marker. - Extends the release workflow to run this smoke test on
schedule/workflow_dispatch.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/integration/test_live_generic_gitlab_install.py | New live smoke test exercising the generic git clone path against GitLab and validating lockfile fields. |
| pyproject.toml | Adds live_generic marker so pytest recognizes the new selection. |
| .github/workflows/build-release.yml | Runs the new smoke test in scheduled/manual workflow runs using repo variable configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an opt-in live smoke test for
apm install gitlab.com/<group>/<repo>so the generic git backend is covered end-to-end against GitLab. The test validates package materialization underapm_modules/and confirmsapm.lock.yamlrecordshost: gitlab.complus a full resolved commit SHA.The smoke is gated behind
APM_LIVE_GENERIC_PACKAGEbecause the fixture suggested in the issue is not currently public. Scheduled/manual CI wiring is included so maintainers can enable it by setting that repository variable to a stable public APM-shaped GitLab repo.Fixes #1229
Type of change
Testing
Validation run:
Focused pytest collected the live smoke and skipped locally because APM_LIVE_GENERIC_PACKAGE is not set, since the GitLab repo suggested one from the issue is not available publicly:
Spec conformance (OpenAPM v0.1)
If this PR changes behaviour that an OpenAPM v0.1 req-XXX covers, confirm the three-step ritual (see CONTRIBUTING.md "Adding or changing a normative requirement"):
Spec edit: docs/src/content/docs/specs/openapm-v0.1.md updated
(new/changed anchor + prose + Appendix C
row).
Manifest edit: docs/src/content/docs/specs/manifests/openapm-v0.1.requirements.yml
updated.
Test edit: a @pytest.mark.req("req-XXX") test under
tests/spec_conformance/ added or extended.
CONFORMANCE.{md,json} regenerated via
uv run --extra dev python -m tests.spec_conformance.gen_statement
and committed.
N/A -- this PR does not change OpenAPM-observable behaviour.