Open
Conversation
Enable bidirectional network testing where both nodes run sender and receiver simultaneously, producing separate TX/RX throughput metrics per direction. Core changes: - NTttcpExecutor: Add DuplexMode property, ExecuteFullDuplexWorkloadAsync with parallel sender+receiver processes, CaptureDirectionalMetrics for per-direction telemetry, role-aware port assignment (forward/reverse), direction-aware -m IP mapping for correct sender→receiver targeting - NetworkingWorkloadState: Add DuplexMode property for client-server state sync - NetworkingWorkloadExecutor: Pass DuplexMode through orchestration instructions Profile: - PERF-NETWORK-NTTTCP-FULLDUPLEX.json: 6 TCP scenarios (T1/T32 x 4K/64K/256K) with DuplexMode=Full, same dependencies as half-duplex profile Tests (21 tests): - NTttcpFullDuplexTests: IsFullDuplex property, ReversePort offset, command-line flag/port/buffer verification for both platforms, execution tests for client send+receive on Linux/Windows, results file separation, half-duplex backward compatibility, NetworkingWorkloadState serialization with DuplexMode Upstream fixes (pre-existing bugs in main): - ProcessProxy.cs: Fix catch clause ordering (general catch before specific) - CommandBase.cs: Fix NullReferenceException on isolationTargets.TargetPackages Verified on real hardware: win-x64 (10.177.236.133) <-> win-arm64 (10.199.102.112) TCP 4K T1: Send 3226 Mbps / Receive 1455 Mbps TCP 64K T1: Send 6490 Mbps / Receive 6163 Mbps
brdeyo
requested changes
Apr 16, 2026
Contributor
brdeyo
left a comment
brdeyo
left a comment
There was a problem hiding this comment.
Please hold up on merging these changes until we have completed the 3.0 production release of VC. We are aiming at having that out today Thursday April 16th. However, I want to prevent anymore major changes to VC core or workloads until we finalize.
brdeyo
reviewed
Apr 16, 2026
|
|
||
| await this.WaitForExitCodeConfirmationAsync(cancellationToken, timeout); | ||
| } | ||
| catch (TimeoutException) when (timeout != null) |
Contributor
There was a problem hiding this comment.
Not needed. There is a generic "catch" block. This catches ALL exceptions including TimeoutException.
brdeyo
requested changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable bidirectional network testing where both nodes run sender and receiver simultaneously, producing separate TX/RX throughput metrics per direction.
Core changes:
Profile:
Tests (21 tests):
Upstream fixes (pre-existing bugs in main):
Verified on real hardware: win-x64 <-> win-arm64
TCP 4K T1: Send 3226 Mbps / Receive 1455 Mbps
TCP 64K T1: Send 6490 Mbps / Receive 6163 Mbps