Fix #7724: Resolve Option 1 Name from existing Shopify Variant records#8048
Open
tVisionDeb wants to merge 1 commit into
Open
Fix #7724: Resolve Option 1 Name from existing Shopify Variant records#8048tVisionDeb wants to merge 1 commit into
tVisionDeb wants to merge 1 commit into
Conversation
…nt records - Modified FillInProductVariantData to call new ResolveOption1Name procedure - ResolveOption1Name queries existing variants for consistent Option 1 Name - Falls back to 'Variant' if no existing variants or names are inconsistent
JesperSchulz
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7724: Variant option names should be resolved from existing Shopify Variant records instead of using hardcoded values.
Changes
ShpfyProductExport.Codeunit.alto callResolveOption1Name()procedure when syncing product variant option namesResolveOption1Name()that queries existing variants for the correct option nameValidation
Test Execution Results
Full test suite executed on BC-28 (container BC-20260506, version 28.0.46665.48932):
Failing tests (pre-existing, unrelated to this change):
Codeunit 139606 - Shpfy Shipping Test (1 failure):
UnitTestExportFulfillmentServiceShipment- Fails with API version check error ("The Shopify Admin API used by your current Shopify connector is no longer supported"). This is a platform-level version mismatch in the test environment.Codeunit 139608 - Shpfy Orders API Test (19 failures):
Relevant passing tests (product export with variants):