Skip to content

Add Copilot PR reviewer#8043

Open
WaelAbuSeada wants to merge 3 commits intomainfrom
feat/copilot-pr-reviewer-port
Open

Add Copilot PR reviewer#8043
WaelAbuSeada wants to merge 3 commits intomainfrom
feat/copilot-pr-reviewer-port

Conversation

@WaelAbuSeada
Copy link
Copy Markdown
Member

@WaelAbuSeada WaelAbuSeada commented May 7, 2026

Ports the Copilot PR reviewer from BCAppsCampAIRHack into BCApps.

Added

  • Workflow: .github/workflows/CopilotPRReview.yaml
  • Reviewer tool: src/Tools/code review/scripts/Invoke-CopilotPRReview.ps1
  • Skill: src/Tools/code review/skills/al-code-review/SKILL.md
  • Instructions:
    • src/Tools/code review/instructions/security.md
    • src/Tools/code review/instructions/privacy.md
    • src/Tools/code review/instructions/performance.md
    • src/Tools/code review/instructions/style.md
    • src/Tools/code review/instructions/upgrade.md
    • src/Tools/code review/instructions/accessibility.md

Path adaptation

  • Workflow now invokes trusted/src/Tools/code review/scripts/Invoke-CopilotPRReview.ps1
  • Script copies trusted skill/instructions from src/Tools/code review/* into the isolated runner workspace.
    Fixes: AB#626808

@WaelAbuSeada WaelAbuSeada requested review from a team as code owners May 7, 2026 15:15
@github-actions github-actions Bot added Build: Automation Workflows and other setup in .github folder AL: Tools labels May 7, 2026
Comment thread src/Tools/code review/scripts/Invoke-CopilotPRReview.ps1 Fixed
@WaelAbuSeada WaelAbuSeada changed the title Add Copilot PR reviewer under src/Tools Add Copilot PR reviewer May 7, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone May 7, 2026
@@ -0,0 +1,1146 @@
<#
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is the right place to put an agent. But we can always move it, if need be. For now, I'll won't argue.

JesperSchulz
JesperSchulz previously approved these changes May 7, 2026
@JesperSchulz
Copy link
Copy Markdown
Contributor

Let's get this agent on the road ASAP 🚀

Copy link
Copy Markdown
Contributor

@mazhelez mazhelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. There are also a couple of actions before the PR could be merged.

name: Copilot PR Review

on:
pull_request_target:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to limit the target branches:
E.g.

branches: [ 'main', 'releases/*' ]

persist-credentials: true

- name: Setup Node.js
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's v6.4.0. Any reason to use such an old version?

& "${{ github.workspace }}/trusted/src/Tools/code review/scripts/Invoke-CopilotPRReview.ps1"

- name: Upload review artifacts
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the newest version is v7.0.1. Quite further ahead.

@@ -0,0 +1,269 @@
---
name: al-code-review
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this ( the "code review" folder) should live in .github, or ./tools, not under src/Tools, as that path is used for AL projects that act as tools in product.

Follow the convention to use capital case for folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Tools Build: Automation Workflows and other setup in .github folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants