fix unbound variable issue in the airlock processor#4929
Open
JC-wk wants to merge 3 commits into
Open
Conversation
## What is being addressed If extract_properties() throws an exception (due to decoding errors or invalid structure) then an error 'request_properties' is not defined would be generated instead of reporting the actual error, masking the original root cause. ## How is this addressed - Define the variables before the try: so they always exist - Update CHANGELOG.md - Increment version
Unit Test Results24 tests 24 ✅ 0s ⏱️ Results for commit 4f465e9. ♻️ This comment has been updated with latest results. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an exception-masking bug in the airlock processor’s StatusChangedQueueTrigger so that failures in extract_properties() don’t cascade into an UnboundLocalError (or subsequent attribute errors) and hide the original root cause.
Changes:
- Initialize
request_properties/request_filesbefore thetryblock inmain(). - Add a guard in
set_output_event_to_report_failure()for cases where request properties could not be extracted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is being addressed
If extract_properties() throws an exception (due to decoding errors or invalid structure) then an error 'request_properties' is not defined would be generated instead of reporting the actual error, masking the original root cause.
How is this addressed