Ensure /test-destroy-env also destroys management RG when core RG is absent

[Copilot]

What is being addressed

/test-destroy-env exited early if the core RG (rg-tre<ref>) was already gone, so prefixed groups like rg-tre<ref>-mgmt were left behind. This left management-state resources undeleted and could preserve stale Terraform state locks.

How is this addressed

• Destroy scope resolution

  • The script now resolves all resource groups with the core prefix first and exits only when none exist.
  • This ensures management RG cleanup still runs even if the core RG no longer exists.

• Core-only cleanup gating

  • Core-specific pre-delete operations (locks/diagnostics/keyvault/log analytics linked storage) now run only when the core RG is present.
  • When absent, the script logs a targeted skip message and continues with group deletion.

• Deletion path reuse

  • Reuses the precomputed RG match list for final deletion to keep selection and execution aligned.

matching_resource_groups=$(az group list --query "[?starts_with(name, '${core_tre_rg}')].[name]" -o tsv | sort -r)
if [[ -z "${matching_resource_groups}" ]]; then
  echo "No resource groups found with prefix ${core_tre_rg} - skipping destroy"
  exit 0
fi

• Follow-ups
  • No additional follow-up work identified.
  • No documentation, changelog, or template version updates were required for this change.

[rudolphjacksonm]

/test

[github-actions]

🤖 pr-bot 🤖

⚠️ When using /test on external PRs, the SHA of the checked commit must be specified

(in response to this comment from @rudolphjacksonm)

[rudolphjacksonm]

/test 2a69a8e

[github-actions]

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/27072873570 (with refid b80dde45)

(in response to this comment from @rudolphjacksonm)

[rudolphjacksonm]

/test-destroy-env

[github-actions]

Destroying branch test environment (RG: rg-trea6436f6c)... (run: https://github.com/microsoft/AzureTRE/actions/runs/27084269577)

[github-actions]

Destroying PR test environment (RG: rg-treb80dde45)... (run: https://github.com/microsoft/AzureTRE/actions/runs/27084269577)

[github-actions]

Branch test environment destroy complete (RG: rg-trea6436f6c)

[github-actions]

PR test environment destroy complete (RG: rg-treb80dde45)

[Copilot]

Pull request overview

Updates the /test-destroy-env deletion script to correctly clean up all TRE-related resource groups (including -mgmt) even when the core resource group (rg-tre<ref>) has already been deleted, preventing leftover management resources/state.

Changes:

• Resolve and cache all resource groups matching the core prefix up front; only exit early when none exist.
• Gate “core RG only” cleanup steps (locks, diagnostics, key vault handling, log analytics linked storage) on the core RG actually existing.
• Reuse the cached matching RG list for the final per-RG purge/delete loop to keep selection consistent.