Skip to content

fix: parse import-url suffixes from right#291

Open
cotishq wants to merge 1 commit intomicrocks:masterfrom
cotishq:fix/import-url-parsing
Open

fix: parse import-url suffixes from right#291
cotishq wants to merge 1 commit intomicrocks:masterfrom
cotishq:fix/import-url-parsing

Conversation

@cotishq
Copy link
Copy Markdown
Contributor

@cotishq cotishq commented May 5, 2026

Description

  • Fix import-url argument parsing so URLs containing : (scheme/ports/etc.) are preserved when using the optional :true|false[:secret] suffixes.
  • Add unit tests covering ports, paths, query strings, fragments, and secret suffix parsing.
  • Update import-url docs with the new parsing behavior and examples.
  • Make context_test create its testdata/ directory before writing the test config file (stabilizes test runs).

Before:

image

After the fix:

image

Related issue(s)

Fixes #260

Signed-off-by: cotishq <tanishqp101204@gmail.com>
@cotishq cotishq force-pushed the fix/import-url-parsing branch from 04d4ed4 to 914cb0e Compare May 5, 2026 13:37
@cotishq
Copy link
Copy Markdown
Contributor Author

cotishq commented May 5, 2026

@Harsh4902 would love your opinion on this and what changes it still requires

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: import-url loses URL path/port when parsing :primary and secret suffixes

1 participant